Skip to content

ACM-20151 Fine grained RBAC UI OWNERS file update#5007

Merged
openshift-merge-bot[bot] merged 1 commit intostolostron:mainfrom
mshort55:rbacownerfileupdate
Sep 16, 2025
Merged

ACM-20151 Fine grained RBAC UI OWNERS file update#5007
openshift-merge-bot[bot] merged 1 commit intostolostron:mainfrom
mshort55:rbacownerfileupdate

Conversation

@mshort55
Copy link
Copy Markdown
Contributor

@mshort55 mshort55 commented Sep 16, 2025

📝 Summary

I request that the virt squad get added to the OWNERS file for the fine grained rbac pages.

Ticket Summary (Title):
ACM Fine Grained RBAC TP [ACM 2.15]

Ticket Link:
https://issues.redhat.com/browse/ACM-20151

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

Signed-off-by: Matthew Short <mshort@redhat.com>
@mshort55
Copy link
Copy Markdown
Contributor Author

/assign @KevinFCormier

@openshift-ci openshift-ci Bot added the lgtm label Sep 16, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, mshort55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants