Skip to content

ACM-24633 RBAC pages authorization overhaul and switch to using recoil for User, Group, and ClusterRole state#5074

Merged
openshift-merge-bot[bot] merged 13 commits intostolostron:mainfrom
mshort55:ACM-23876
Oct 9, 2025
Merged

ACM-24633 RBAC pages authorization overhaul and switch to using recoil for User, Group, and ClusterRole state#5074
openshift-merge-bot[bot] merged 13 commits intostolostron:mainfrom
mshort55:ACM-23876

Conversation

@mshort55
Copy link
Copy Markdown
Contributor

@mshort55 mshort55 commented Oct 7, 2025

📝 Summary

Ticket Summary (Title):
RBAC UI Implementation - multicluster-role-assignment authorization

Ticket Link:
https://issues.redhat.com/browse/ACM-24633

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

@mshort55
Copy link
Copy Markdown
Contributor Author

mshort55 commented Oct 8, 2025

/assign @oksanabaza @kurwang

We will merge after Oksana's "All Namespaces" PR. I only fixed sonar issues related to the UserManagement dir files and left other issues as is. I am not confident enough to fix those.

…d with button level RBAC

Signed-off-by: Matthew Short <mshort@redhat.com>
…and frontend atoms. Sorted recoil related things alphabetically. Removed old/unused access-control file.

Signed-off-by: Matthew Short <mshort@redhat.com>
…) to recoil atom for roles state data

Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
@oksanabaza
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 8, 2025
… to recoil for state. Removed all loading page components.

Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
…ser and group state

Signed-off-by: Matthew Short <mshort@redhat.com>
… roles

Signed-off-by: Matthew Short <mshort@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm label Oct 9, 2025
@mshort55
Copy link
Copy Markdown
Contributor Author

mshort55 commented Oct 9, 2025

@oksanabaza can you review the newest 4 commits? I forgot to update some User and Group components previously. Now everything is fully updated to use User and Group recoil state and not through direct kube api query. Things do seem considerably faster on those pages. I had to remove the page loading components (sorry about this, I think you worked on them!) Recoil state doesn't have a similar detectable loading state as we had previously with direct kube api requests. Recoil loading state and empty state are both empty arrays. However I don't think we will need the loading pages using recoil (at least I hope, let's see).

Signed-off-by: Matthew Short <mshort@redhat.com>
@oksanabaza
Copy link
Copy Markdown
Contributor

/lgtm

@mshort55
Copy link
Copy Markdown
Contributor Author

mshort55 commented Oct 9, 2025

/assign @KevinFCormier

@KevinFCormier
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the lgtm label Oct 9, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, mshort55, oksanabaza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 9, 2025

@openshift-merge-bot openshift-merge-bot Bot merged commit 9847e95 into stolostron:main Oct 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants