ACM-24633 RBAC pages authorization overhaul and switch to using recoil for User, Group, and ClusterRole state#5074
Conversation
|
/assign @oksanabaza @kurwang We will merge after Oksana's "All Namespaces" PR. I only fixed sonar issues related to the UserManagement dir files and left other issues as is. I am not confident enough to fix those. |
…d with button level RBAC Signed-off-by: Matthew Short <mshort@redhat.com>
…and frontend atoms. Sorted recoil related things alphabetically. Removed old/unused access-control file. Signed-off-by: Matthew Short <mshort@redhat.com>
…) to recoil atom for roles state data Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
|
/lgtm |
… to recoil for state. Removed all loading page components. Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
…ser and group state Signed-off-by: Matthew Short <mshort@redhat.com>
… roles Signed-off-by: Matthew Short <mshort@redhat.com>
|
@oksanabaza can you review the newest 4 commits? I forgot to update some User and Group components previously. Now everything is fully updated to use User and Group recoil state and not through direct kube api query. Things do seem considerably faster on those pages. I had to remove the page loading components (sorry about this, I think you worked on them!) Recoil state doesn't have a similar detectable loading state as we had previously with direct kube api requests. Recoil loading state and empty state are both empty arrays. However I don't think we will need the loading pages using recoil (at least I hope, let's see). |
|
/lgtm |
|
/assign @KevinFCormier |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinFCormier, mshort55, oksanabaza The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|



📝 Summary
Ticket Summary (Title):
RBAC UI Implementation - multicluster-role-assignment authorization
Ticket Link:
https://issues.redhat.com/browse/ACM-24633
Type of Change:
✅ Checklist
General
ACM-12340 Fix bug with...)If Feature
If Bugfix
🗒️ Notes for Reviewers