Skip to content

ACM-24738 RBAC UI - group membership is not working#5084

Merged
openshift-merge-bot[bot] merged 6 commits intostolostron:mainfrom
oksanabaza:ACM-25041
Oct 10, 2025
Merged

ACM-24738 RBAC UI - group membership is not working#5084
openshift-merge-bot[bot] merged 6 commits intostolostron:mainfrom
oksanabaza:ACM-25041

Conversation

@oksanabaza
Copy link
Copy Markdown
Contributor

@oksanabaza oksanabaza commented Oct 9, 2025

📝 Summary

Ticket Summary (Title):

ACM-24738 RBAC UI - group membership is not working

Ticket Link:

https://issues.redhat.com/browse/ACM-24738

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

@oksanabaza
Copy link
Copy Markdown
Contributor Author

oksanabaza commented Oct 9, 2025

this PR should be merged after #5074 and adjusted to get groups via recoil

@oksanabaza
Copy link
Copy Markdown
Contributor Author

oksanabaza commented Oct 9, 2025

/assign @mshort55 @kurwang

mshort55
mshort55 suggested changes Oct 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mshort55 mshort55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. See my 1 comment on function location. #5074 was merged, so you are good to rebase and update what you need to use recoil if anything.

Comment thread frontend/src/resources/clients/multicluster-role-assignment-client.ts Outdated
@oksanabaza
ACM-24738 RBAC UI - group membership is not working
1bec146 
Signed-off-by: Oksana Bazylieva <obazylie@redhat.com>
@oksanabaza
Move findGroupsContainingUser function to UserGroups file
e7f552a 
Signed-off-by: Oksana Bazylieva <obazylie@redhat.com>
@oksanabaza
Refactor UserGroups code and set isPreProcessed to false to enable so…
86d4f51 
…rting in tables

Signed-off-by: Oksana Bazylieva <obazylie@redhat.com>
@openshift-ci openshift-ci Bot added the approved label Oct 9, 2025
@oksanabaza
Make useUserGroups reusable and pass groups to UserYaml file
0ce281a 
Signed-off-by: Oksana Bazylieva <obazylie@redhat.com>
@oksanabaza
Remove roleAssignmentToFlattenedRoleAssignment export and following T…
d1db304 
…ODO item

Signed-off-by: Oksana Bazylieva <obazylie@redhat.com>
@openshift-ci openshift-ci Bot removed the approved label Oct 9, 2025
@mshort55
Copy link
Copy Markdown
Contributor

mshort55 commented Oct 9, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 9, 2025
@oksanabaza
Adjust tests for UserGroups file
fc174e0 
Signed-off-by: Oksana Bazylieva <obazylie@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm label Oct 9, 2025
@oksanabaza
Copy link
Copy Markdown
Contributor Author

oksanabaza commented Oct 10, 2025

/retest

@mshort55
Copy link
Copy Markdown
Contributor

mshort55 commented Oct 10, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 10, 2025
@mshort55
Copy link
Copy Markdown
Contributor

mshort55 commented Oct 10, 2025

/assign @KevinFCormier

Can you help me merge this please?

@KevinFCormier
Copy link
Copy Markdown
Contributor

KevinFCormier commented Oct 10, 2025

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, mshort55, oksanabaza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshort55
Copy link
Copy Markdown
Contributor

mshort55 commented Oct 10, 2025

/retest

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 10, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
1 Accepted issue

Measures
1 Security Hotspot
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@openshift-merge-bot openshift-merge-bot Bot merged commit 8cc5572 into stolostron:main Oct 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mshort55 mshort55 mshort55 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@KevinFCormier KevinFCormier

@kurwang kurwang

@mshort55 mshort55

Labels

approved dco-signoff: yes lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oksanabaza @mshort55 @KevinFCormier @kurwang