ACM-24275 and ACM-24267 - Implemented global role logic and MRA creation logic fix#5024
Conversation
…ssignment creation. Fixed MRA creation logic in client to patch instead of create if user MRA exists already.. Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
|
/retest |
|
/assign @oksanabaza @kurwang |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
| scope: { | ||
| ...prevData.scope, | ||
| clusterNames: roleAssignmentData.allClusterNames, | ||
| namespaces: undefined, |
There was a problem hiding this comment.
I am fine with undefined but would it be better to say like includes all namespaces or like all namespaces?
There was a problem hiding this comment.
Undefined is actually intentional here. If namespaces is undefined, that means that targetNamespaces does not get added on the MRA RoleAssignment (this creates a ClusterRoleBinding when targetNamespaces is not present in the spec). This is actually what we want here, if all is selected, for namespaces to be empty or undefined. On the UI itself, empty or undefined namespaces does get translated and shows "All Namespaces".
There was a problem hiding this comment.
ah i see i agree! that clears it up thanks!
|
/hold |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinFCormier, kurwang, mshort55, oksanabaza The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
4 participants
📝 Summary
Implemented global role RA creation and fixed MRA creation logic to choose existing MRA for user if exists.
Ticket Summary (Title):
RBAC UI Implementation - Propogate to all (global role) during role assignment creation
RBAC UI Implementation - update MRA client for single user MRA creation/edit
Ticket Link:
https://issues.redhat.com/browse/ACM-24275
https://issues.redhat.com/browse/ACM-24267
Type of Change:
✅ Checklist
General
ACM-12340 Fix bug with...)If Feature
If Bugfix
🗒️ Notes for Reviewers