Skip to content

winch: Fix a host panic when executing table.fill #13010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfallin merged 1 commit into from
Apr 9, 2026
Merged

winch: Fix a host panic when executing table.fill #13010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions tests/misc_testsuite/winch/table_fill.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,39 @@
(invoke "fill" (i32.const 8) (i32.const 0) (i32.const 3))
"out of bounds table access"
)

(module $t
(table (export "t") 1 funcref)
)

(module
(import "t" "t" (table $t1 1 funcref))
(table $t2 2 funcref)

(func (export "fill1") (param i32 funcref i32)
local.get 0
local.get 1
local.get 2
table.fill $t1)

(func (export "fill2") (param i32 funcref i32)
local.get 0
local.get 1
local.get 2
table.fill $t2)
)

(assert_return (invoke "fill1" (i32.const 0) (ref.null func) (i32.const 0)))
(assert_return (invoke "fill1" (i32.const 0) (ref.null func) (i32.const 1)))
(assert_return (invoke "fill1" (i32.const 1) (ref.null func) (i32.const 0)))
(assert_trap (invoke "fill1" (i32.const 2) (ref.null func) (i32.const 0))
"out of bounds table access")

(assert_return (invoke "fill2" (i32.const 0) (ref.null func) (i32.const 0)))
(assert_return (invoke "fill2" (i32.const 0) (ref.null func) (i32.const 1)))
(assert_return (invoke "fill2" (i32.const 0) (ref.null func) (i32.const 2)))
(assert_return (invoke "fill2" (i32.const 1) (ref.null func) (i32.const 0)))
(assert_return (invoke "fill2" (i32.const 1) (ref.null func) (i32.const 1)))
(assert_return (invoke "fill2" (i32.const 2) (ref.null func) (i32.const 0)))
(assert_trap (invoke "fill2" (i32.const 3) (ref.null func) (i32.const 0))
"out of bounds table access")
10 changes: 3 additions & 7 deletions winch/codegen/src/visitor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1805,13 +1805,9 @@ where

let at = self.context.stack.ensure_index_at(3)?;

self.context.stack.insert_many(at, &[table.try_into()?]);
FnCall::emit::<M>(
&mut self.env,
self.masm,
&mut self.context,
Callee::Builtin(builtin.clone()),
)?;
let callee = self.prepare_builtin_defined_table_arg(table_index, at, builtin)?;
FnCall::emit::<M>(&mut self.env, self.masm, &mut self.context, callee)?;

self.context.pop_and_free(self.masm)
}

Expand Down
Loading