winch: Fix a host panic when executing table.fill#13010
Merged
cfallin merged 1 commit intobytecodealliance:mainfrom Apr 9, 2026
Merged
winch: Fix a host panic when executing table.fill#13010cfallin merged 1 commit intobytecodealliance:mainfrom
table.fill#13010cfallin merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit fixes a possible panic when a Winch-compiled module executes the `table.fill` instruction. Refactoring in bytecodealliance#11254 updated Cranelift but forgot to update Winch meaning that Winch's indices were still using the module-level indices instead of the `DefinedTableIndex` space. This adds some tests and updates Winch's translation to use preexisting helpers.
cfallin
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a possible panic when a Winch-compiled module executes the
table.fillinstruction. Refactoring in #11254 updated Cranelift but forgot to update Winch meaning that Winch's indices were still using the module-level indices instead of theDefinedTableIndexspace. This adds some tests and updates Winch's translation to use preexisting helpers.