Skip to content

Add ovn local gateway CI gate #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yboaron wants to merge 2 commits into
base: devel
Choose a base branch
from
+1 −0
Open

Add ovn local gateway CI gate #3905

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23133b4
Add ovn local gateway CI gate
yboaron Mar 15, 2026
d40742f
Merge branch 'devel' into add_ovn_lgw_gate
tpantelis Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
- extra-toggles: dual-stack, vxlan
- extra-toggles: dual-stack, ovn, vxlan
- extra-toggles: ovn, intra-cluster-disabled
- extra-toggles: ovn, ovn-lgw
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify that `ovn-lgw` is implemented beyond matrix declaration.
# Expected:
# - At least one consumer of `ovn-lgw` outside `.github/workflows/e2e.yml`
# - A code/config path that maps it to OVN local-gateway behavior.

echo "== All ovn-lgw references =="
rg -n -C3 '\bovn-lgw\b'

echo "== Workflow toggle plumbing =="
rg -n -C3 'extra-toggles|using:\s*\$\{\{\s*matrix\.globalnet' .github/workflows/e2e.yml

echo "== OVN shipyard config currently used =="
sed -n '1,120p' .shipyard.e2e.ovn.yml

Repository: submariner-io/submariner

Length of output: 2020

Remove ovn-lgw from the matrix unless it is implemented

Line 72 adds extra-toggles: ovn, ovn-lgw, but ovn-lgw does not appear anywhere else in the codebase. This matrix entry creates a duplicate OVN test run without any functional difference. Either implement LGW-specific behavior and wire it through the e2e action, or remove this toggle from the matrix.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/e2e.yml at line 72, The matrix entry adds the toggle
"ovn-lgw" under extra-toggles but that toggle is not implemented; remove
"ovn-lgw" from the extra-toggles list in the GitHub Actions workflow matrix to
avoid a duplicate OVN run, or if you intend to support LGW behavior implement
and wire the "ovn-lgw" toggle through the e2e action (add handling for the
"ovn-lgw" value where extra-toggles is parsed and ensure tests/configs respect
it). Refer to the "extra-toggles" matrix key and the "ovn-lgw" toggle name when
making the change.

# Oldest Kubernetes version thought to work with SubM.
# If this breaks, we may advance the oldest-working K8s version instead of fixing it. See:
# https://submariner.io/development/building-testing/ci-maintenance/
Expand Down
Loading