Add ovn local gateway CI gate#3905
Conversation
Extend CI coverage to include OVN local GW mode Signed-off-by: Yossi Boaron <yboaron@redhat.com>
|
🤖 Created branch: z_pr3905/yboaron/add_ovn_lgw_gate |
WalkthroughAdds a new matrix entry to the e2e-full job in the GitHub Actions workflow, introducing an additional test configuration that combines OVN and OVN-LGW toggles for expanded test coverage. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/e2e.yml:
- Line 72: The matrix entry adds the toggle "ovn-lgw" under extra-toggles but
that toggle is not implemented; remove "ovn-lgw" from the extra-toggles list in
the GitHub Actions workflow matrix to avoid a duplicate OVN run, or if you
intend to support LGW behavior implement and wire the "ovn-lgw" toggle through
the e2e action (add handling for the "ovn-lgw" value where extra-toggles is
parsed and ensure tests/configs respect it). Refer to the "extra-toggles" matrix
key and the "ovn-lgw" toggle name when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b83a742d-6a3d-47cc-b696-81b687a81da3
📒 Files selected for processing (1)
.github/workflows/e2e.yml
| - extra-toggles: dual-stack, vxlan | ||
| - extra-toggles: dual-stack, ovn, vxlan | ||
| - extra-toggles: ovn, intra-cluster-disabled | ||
| - extra-toggles: ovn, ovn-lgw |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify that `ovn-lgw` is implemented beyond matrix declaration.
# Expected:
# - At least one consumer of `ovn-lgw` outside `.github/workflows/e2e.yml`
# - A code/config path that maps it to OVN local-gateway behavior.
echo "== All ovn-lgw references =="
rg -n -C3 '\bovn-lgw\b'
echo "== Workflow toggle plumbing =="
rg -n -C3 'extra-toggles|using:\s*\$\{\{\s*matrix\.globalnet' .github/workflows/e2e.yml
echo "== OVN shipyard config currently used =="
sed -n '1,120p' .shipyard.e2e.ovn.ymlRepository: submariner-io/submariner
Length of output: 2020
Remove ovn-lgw from the matrix unless it is implemented
Line 72 adds extra-toggles: ovn, ovn-lgw, but ovn-lgw does not appear anywhere else in the codebase. This matrix entry creates a duplicate OVN test run without any functional difference. Either implement LGW-specific behavior and wire it through the e2e action, or remove this toggle from the matrix.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/e2e.yml at line 72, The matrix entry adds the toggle
"ovn-lgw" under extra-toggles but that toggle is not implemented; remove
"ovn-lgw" from the extra-toggles list in the GitHub Actions workflow matrix to
avoid a duplicate OVN run, or if you intend to support LGW behavior implement
and wire the "ovn-lgw" toggle through the e2e action (add handling for the
"ovn-lgw" value where extra-toggles is parsed and ensure tests/configs respect
it). Refer to the "extra-toggles" matrix key and the "ovn-lgw" toggle name when
making the change.
|
Merging submariner-io/shipyard#2350 is prereq for creating ovnk local gateway clusters. |
|
This gate is expected to fail until ovn-kubernetes/ovn-kubernetes#6030 is merged (and of course Shipyard OVNK should include this fix) . We should move this gate to required when ovnk PR is merged |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
Extend CI coverage to include OVN local GW mode
Summary by CodeRabbit