Skip to content

Add ovn local gateway CI gate#3905

Open
yboaron wants to merge 2 commits intosubmariner-io:develfrom
yboaron:add_ovn_lgw_gate
Open

Add ovn local gateway CI gate#3905
yboaron wants to merge 2 commits intosubmariner-io:develfrom
yboaron:add_ovn_lgw_gate

Conversation

@yboaron
Copy link
Copy Markdown
Contributor

@yboaron yboaron commented Mar 15, 2026

Extend CI coverage to include OVN local GW mode

Summary by CodeRabbit

  • Tests
    • Expanded end-to-end test coverage to include OVN LGW toggle configuration combinations, ensuring broader compatibility validation across additional configuration scenarios.

Extend CI coverage to include OVN local GW mode

Signed-off-by: Yossi Boaron <yboaron@redhat.com>
@submariner-bot
Copy link
Copy Markdown
Contributor

🤖 Created branch: z_pr3905/yboaron/add_ovn_lgw_gate
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 15, 2026

Walkthrough

Adds a new matrix entry to the e2e-full job in the GitHub Actions workflow, introducing an additional test configuration that combines OVN and OVN-LGW toggles for expanded test coverage.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/e2e.yml
Added a new matrix entry for extra-toggles: ovn, ovn-lgw to the e2e-full job, expanding the test matrix to include this toggle combination.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Actionable Comments Resolved ❓ Inconclusive The ovn-lgw matrix entry and any related actionable comments could not be verified due to missing context about the specific file location, line numbers, or the exact nature of the actionable comment being investigated. Provide the specific file path, line numbers, and details of the actionable comment to enable proper verification of whether the ovn-lgw matrix entry issue has been resolved.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding OVN local gateway mode to CI testing matrix.
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/e2e.yml:
- Line 72: The matrix entry adds the toggle "ovn-lgw" under extra-toggles but
that toggle is not implemented; remove "ovn-lgw" from the extra-toggles list in
the GitHub Actions workflow matrix to avoid a duplicate OVN run, or if you
intend to support LGW behavior implement and wire the "ovn-lgw" toggle through
the e2e action (add handling for the "ovn-lgw" value where extra-toggles is
parsed and ensure tests/configs respect it). Refer to the "extra-toggles" matrix
key and the "ovn-lgw" toggle name when making the change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b83a742d-6a3d-47cc-b696-81b687a81da3

📥 Commits

Reviewing files that changed from the base of the PR and between 2114349 and 23133b4.

📒 Files selected for processing (1)
  • .github/workflows/e2e.yml

Comment thread .github/workflows/e2e.yml
- extra-toggles: dual-stack, vxlan
- extra-toggles: dual-stack, ovn, vxlan
- extra-toggles: ovn, intra-cluster-disabled
- extra-toggles: ovn, ovn-lgw
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify that `ovn-lgw` is implemented beyond matrix declaration.
# Expected:
# - At least one consumer of `ovn-lgw` outside `.github/workflows/e2e.yml`
# - A code/config path that maps it to OVN local-gateway behavior.

echo "== All ovn-lgw references =="
rg -n -C3 '\bovn-lgw\b'

echo "== Workflow toggle plumbing =="
rg -n -C3 'extra-toggles|using:\s*\$\{\{\s*matrix\.globalnet' .github/workflows/e2e.yml

echo "== OVN shipyard config currently used =="
sed -n '1,120p' .shipyard.e2e.ovn.yml

Repository: submariner-io/submariner

Length of output: 2020


Remove ovn-lgw from the matrix unless it is implemented

Line 72 adds extra-toggles: ovn, ovn-lgw, but ovn-lgw does not appear anywhere else in the codebase. This matrix entry creates a duplicate OVN test run without any functional difference. Either implement LGW-specific behavior and wire it through the e2e action, or remove this toggle from the matrix.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/e2e.yml at line 72, The matrix entry adds the toggle
"ovn-lgw" under extra-toggles but that toggle is not implemented; remove
"ovn-lgw" from the extra-toggles list in the GitHub Actions workflow matrix to
avoid a duplicate OVN run, or if you intend to support LGW behavior implement
and wire the "ovn-lgw" toggle through the e2e action (add handling for the
"ovn-lgw" value where extra-toggles is parsed and ensure tests/configs respect
it). Refer to the "extra-toggles" matrix key and the "ovn-lgw" toggle name when
making the change.

@yboaron yboaron added the ready-to-test When a PR is ready for full E2E testing label Mar 15, 2026
@yboaron yboaron marked this pull request as draft March 15, 2026 12:50
@yboaron
Copy link
Copy Markdown
Contributor Author

yboaron commented Mar 15, 2026

Merging submariner-io/shipyard#2350 is prereq for creating ovnk local gateway clusters.

@yboaron yboaron marked this pull request as ready for review March 17, 2026 07:22
@yboaron
Copy link
Copy Markdown
Contributor Author

yboaron commented Mar 17, 2026

This gate is expected to fail until ovn-kubernetes/ovn-kubernetes#6030 is merged (and of course Shipyard OVNK should include this fix) .

We should move this gate to required when ovnk PR is merged

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-test When a PR is ready for full E2E testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants