Skip to content

Muted StatusEffects#43668

Open
Pok27 wants to merge 12 commits intospace-wizards:masterfrom
Pok27:MutedStatusEffects
Open

Muted StatusEffects#43668
Pok27 wants to merge 12 commits intospace-wizards:masterfrom
Pok27:MutedStatusEffects

Conversation

@Pok27
Copy link
Copy Markdown
Contributor

@Pok27 Pok27 commented Apr 20, 2026 •
edited
Loading

About the PR

Converts Muted into new status effects.

Why / Balance

#38575

Technical details

The PermanentStatusEffectsComponent has been added to remove the MutedComponent and apply the effect through entity effects

A minor refactoring was also performed the component now has field popups so that other systems can override them, rather than hard-coding HasComp directly in MutedSystem.

Media

Requirements

Breaking changes

The Muted status effect has been removed and replaced with StatusEffectMuted for the new status effect system.
The MutedComponent has been removed and replaced with MutedStatusEffectComponent

Changelog

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines. labels Apr 20, 2026
@Pok27 Pok27 added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Apr 20, 2026
Princess-Cheeseballs
Princess-Cheeseballs requested changes Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Princess-Cheeseballs Princess-Cheeseballs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things

Comment thread Content.Server/Speech/EntitySystems/SpeakOnActionSystem.cs Outdated
Comment thread Content.Shared/Speech/Muting/MutedSystem.cs Outdated
@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Apr 24, 2026
TheShuEd
TheShuEd reviewed Apr 24, 2026
View reviewed changes
Comment thread Content.Shared/Abilities/Mime/MimePowersSystem.cs Outdated
TheShuEd
TheShuEd reviewed Apr 24, 2026
View reviewed changes
Comment thread Content.Shared/Speech/Muting/MutedComponent.cs Outdated
@github-actions github-actions Bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Pok27 Pok27 mentioned this pull request Apr 24, 2026
Open
2 tasks
@Pok27
Copy link
Copy Markdown
Contributor Author

Pok27 commented Apr 24, 2026

I added the PermanentStatusEffectsComponent to this PR because it requires relatively little code, but I can split it into two PRs if necessary

@github-actions github-actions Bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Apr 24, 2026
Princess-Cheeseballs
Princess-Cheeseballs requested changes Apr 25, 2026
View reviewed changes
Comment thread Resources/Prototypes/Traits/disabilities.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheShuEd TheShuEd TheShuEd left review comments

@Princess-Cheeseballs Princess-Cheeseballs Princess-Cheeseballs requested changes

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@sowelipililimute sowelipililimute Awaiting requested review from sowelipililimute sowelipililimute is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Awaiting Changes Status: Changes are required before another review can happen size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Pok27 @Princess-Cheeseballs @TheShuEd @PJBot