Skip to content

PressureImmunity StatusEffects - #43667

Merged
AJCM-git merged 16 commits into
space-wizards:masterfrom
Pok27:PressureImmunityStatusEffects
Aug 2, 2026
Merged

PressureImmunity StatusEffects#43667
AJCM-git merged 16 commits into
space-wizards:masterfrom
Pok27:PressureImmunityStatusEffects

Conversation

@Pok27

@Pok27 Pok27 commented Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

About the PR

Converts PressureImmunity into new status effects.
PermanentStatusEffects by #43668

Why / Balance

#38575
fix #43620

Media

Requirements

Breaking changes

Changelog

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. labels Apr 20, 2026
@Pok27 Pok27 changed the title PressureImmunityStatusEffects PressureImmunity StatusEffects Apr 20, 2026
@Pok27
Pok27 marked this pull request as draft April 20, 2026 10:55
@Pok27
Pok27 marked this pull request as ready for review April 20, 2026 14:20
Princess-Cheeseballs
Princess-Cheeseballs requested changes Apr 20, 2026
View reviewed changes

@Princess-Cheeseballs Princess-Cheeseballs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using relay events rather than having the status effect modify a component on the entity itself.

I'd use GravitySystem as an example for how to go about doing this.

@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Apr 20, 2026
@PJBot PJBot added size/M Denotes a PR that changes 100-999 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Apr 20, 2026
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Apr 20, 2026
@Pok27 Pok27 added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature LABEL TO BE REMOVED: D3: Low Difficulty: Some codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Apr 20, 2026
ThanosDeGraf
ThanosDeGraf suggested changes Apr 21, 2026
View reviewed changes

@ThanosDeGraf ThanosDeGraf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are doing this, fix #43620 as well. Checked out your PR locally and the crash still occurs when metabolizing Barozine (aka. a source of StatusEffectPressureImmunity)

@ThanosDeGraf

ThanosDeGraf commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

If you are doing this, fix #43620 as well. Checked out your PR locally and the crash still occurs when metabolizing Barozine (aka. a source of StatusEffectPressureImmunity)

DIsregard what I wrote here. I hate this little shit that I need to delete every time I clone the repo with a firey passion.
grafik

After doing so yea cool no more crash, you can mention in the PR description that it resolves #43620.

@Princess-Cheeseballs Princess-Cheeseballs self-assigned this Apr 24, 2026
@PJBot PJBot added the S: Awaiting Changes Status: Changes are required before another review can happen label Apr 24, 2026
Princess-Cheeseballs
Princess-Cheeseballs previously requested changes Apr 24, 2026
View reviewed changes
Comment thread Resources/Prototypes/Entities/Mobs/NPCs/animals.yml
@ReeZer2 ReeZer2 mentioned this pull request May 8, 2026
Merged
5 tasks
@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions Bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label May 9, 2026
@github-actions github-actions Bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label May 13, 2026
@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions Bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 19, 2026
@github-actions github-actions Bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 29, 2026
AJCM-git
AJCM-git requested changes Jul 30, 2026
View reviewed changes
Comment thread Content.Server/Atmos/EntitySystems/PressureImmunityStatusEffectSystem.cs Outdated
Comment thread Content.Server/Atmos/EntitySystems/BarotraumaSystem.cs Outdated
@github-actions github-actions Bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 30, 2026
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions Bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 30, 2026
AJCM-git
AJCM-git requested changes Aug 1, 2026
View reviewed changes

@AJCM-git AJCM-git left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build (and test) before pushing

@AJCM-git
AJCM-git added this pull request to the merge queue Aug 2, 2026
Merged via the queue into space-wizards:master with commit 5148a44 Aug 2, 2026
10 checks passed
Golubgik pushed a commit to Golubgik/space-station that referenced this pull request Aug 3, 2026
@Pok27
PressureImmunity StatusEffects (space-wizards#43667)
c1f9ec5 
* PressureImmunityStatusEffects

* System

* fix

* fix 2

* oops

* review

* review

* fix

* Update PressureImmunityStatusEffectSystem.cs

* PermanentStatusEffectsSystem

* fix

* oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AJCM-git AJCM-git AJCM-git approved these changes
@Princess-Cheeseballs Princess-Cheeseballs Princess-Cheeseballs left review comments
@ArtisticRoomba ArtisticRoomba Awaiting requested review from ArtisticRoomba ArtisticRoomba is a code owner
@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner
@sowelipililimute sowelipililimute Awaiting requested review from sowelipililimute
+1 more reviewer
@ThanosDeGraf ThanosDeGraf ThanosDeGraf requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Princess-Cheeseballs Princess-Cheeseballs

Labels

LABEL TO BE REMOVED: D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Awaiting Changes Status: Changes are required before another review can happen size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Metabolizing Barozine crashes the client

5 participants

@Pok27 @ThanosDeGraf @AJCM-git @Princess-Cheeseballs @PJBot