chore: add test filesystem capabilities#1578
Merged
Conversation
ianbotsf
added
the
no-changelog
luigi617
reviewed
Apr 27, 2026
| */ | ||
| @InternalApi | ||
| public class TestPlatformProvider( | ||
| public class TestPlatformProvider |
Collaborator
There was a problem hiding this comment.
Question: is there any reason why this class is not under test dir if it is meant for testing?
Collaborator
Author
There was a problem hiding this comment.
TestPlatformProvider is one of our utility classes. It's used in runtime-core but also in other modules (e.g., in aws-http, smithy-client, etc.). Dependencies must be in a main source set (e.g., commonMain, jvmMain, etc.) to be visible to other modules.
An argument could be made this belongs in :runtime:testing instead but moving it would be a breaking change so it'll probably stay here for the time being.
luigi617
approved these changes
Apr 27, 2026
Collaborator
luigi617
left a comment
luigi617
left a comment
There was a problem hiding this comment.
Just have a question and looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This change adds some new capabilities to
TestPlatformProviderto facilitate verifying permissions on files in unit tests.Downstream PR: aws/aws-sdk-kotlin#1877
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.