feat: write cached auth files with 600 POSIX perms#1877
Open
feat: write cached auth files with 600 POSIX perms#1877
600 POSIX perms#1877Conversation
|
A new generated diff is ready to view. |
luigi617
reviewed
Apr 28, 2026
|
|
||
| /** | ||
| * Identifies a set of permissions to apply when writing cached auth files (e.g., during cache token refresh for SSO or | ||
| * AWS Login credentials). These values have no effect on Windows. |
Collaborator
There was a problem hiding this comment.
Question: How permission is provided for windows? or We know that cashed auth files won't never be used in window
Collaborator
Author
There was a problem hiding this comment.
Users on Windows get OS-default permissions. This was an intentional choice by the specification.
luigi617
approved these changes
Apr 28, 2026
Collaborator
luigi617
left a comment
luigi617
left a comment
There was a problem hiding this comment.
Leave a question in the comment to understand the context, but it looks good to me
ianbotsf
added
the
ready-for-release
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This change begins writing cached auth token files with permissions
600—user read/write—on POSIX OSes (e.g., Linux and Mac).This is a behavioral change so a new configuration property is added (
AWS_CACHED_AUTH_FILE_PERMISSIONSet al.) allowing users to opt back into the old behavior (i.e.,OS_DEFAULT—use OS-default permissions for new files in the given directory). Otherwise, the default behavior isUSER_READ_WRITE.Upstream PR: smithy-lang/smithy-kotlin#1578
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.