Skip to content

Make syslog identifier more intuitive #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fangebee wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Make syslog identifier more intuitive #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion emailproxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ class Log:
_LOGGER = None
_HANDLER = None
_DATE_FORMAT = '%Y-%m-%d %H:%M:%S:'
_SYSLOG_MESSAGE_FORMAT = '%s: %%(message)s' % APP_NAME
Copy link
Copy Markdown
Owner

@simonrob simonrob Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the name makes sense, but why do we need to remove the : too?

Copy link
Copy Markdown
Author

@fangebee fangebee Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this woould make the : part of the syslog identifier, which is not desirable IMO

Copy link
Copy Markdown
Owner

@simonrob simonrob Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this further, would it be better to remove _SYSLOG_MESSAGE_FORMAT entirely, and just use APP_SHORT_NAME when setting up the logger? That would fall back to the logger's standard format, which is likely to be more widely expected/supported.

Copy link
Copy Markdown
Owner

@simonrob simonrob Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering whether you had any thoughts on this?

Copy link
Copy Markdown
Author

@fangebee fangebee Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for not replying, I need some time to prepare a staging platform for testing things, because the platform where I deployed emailproxy is now in production.

_SYSLOG_MESSAGE_FORMAT = '%s %%(message)s' % APP_SHORT_NAME
_MACOS_USE_SYSLOG = False

@staticmethod
Expand Down