Conversation
| _LOGGER = None | ||
| _HANDLER = None | ||
| _DATE_FORMAT = '%Y-%m-%d %H:%M:%S:' | ||
| _SYSLOG_MESSAGE_FORMAT = '%s: %%(message)s' % APP_NAME |
There was a problem hiding this comment.
Changing the name makes sense, but why do we need to remove the : too?
There was a problem hiding this comment.
this woould make the : part of the syslog identifier, which is not desirable IMO
There was a problem hiding this comment.
Thinking about this further, would it be better to remove _SYSLOG_MESSAGE_FORMAT entirely, and just use APP_SHORT_NAME when setting up the logger? That would fall back to the logger's standard format, which is likely to be more widely expected/supported.
There was a problem hiding this comment.
Just wondering whether you had any thoughts on this?
There was a problem hiding this comment.
sorry for not replying, I need some time to prepare a staging platform for testing things, because the platform where I deployed emailproxy is now in production.
2 participants
My fix for #411