Skip to content

[unuran] download from LCG instead of bundle builtin and use CMake target#21946

Merged
guitargeek merged 9 commits into
root-project:masterfrom
ferdymercury:bunur2
Jun 30, 2026
Merged

[unuran] download from LCG instead of bundle builtin and use CMake target#21946
guitargeek merged 9 commits into
root-project:masterfrom
ferdymercury:bunur2

Conversation

@ferdymercury

Copy link
Copy Markdown
Collaborator

Variant of #21938 but using LCG link

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 15h 37m 53s ⏱️
 3 876 tests  3 827 ✅   0 💤 49 ❌
78 546 runs  78 222 ✅ 275 💤 49 ❌

For more details on these failures, see this check.

Results for commit b48ba54.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo self-assigned this Apr 19, 2026
as done by bellenot in libgif etc
@ferdymercury

Copy link
Copy Markdown
Collaborator Author

gentle ping @lmoneta

Comment thread builtins/unuran/0001-allow-compilation-from-CMake.patch
@ferdymercury ferdymercury reopened this Jun 3, 2026
@dpiparo

dpiparo commented Jun 8, 2026

Copy link
Copy Markdown
Member

thanks for these changes.
The only difference between unuran and other packages now not in source, e.g. lzma, is that it is not installable on linux and mac: indeed unuran is not present in Homebrew. This is not a blocker, but certainly something that introduces a symmetry, requiring always to have an internet connection on mac, because it is not possible to install locally all ROOT dependencies (unuran does not exist in brew)

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

Yep, libunuran-dev exists on latest ubuntu and unuran-devel exists on alma, but not on homebrew for mac.
Do we know of someone with experience with homebrew that could be willing to give it a try to adding a formula for it so that we can restore symmetry? Maybe @henryiii ?

@ferdymercury

ferdymercury commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

mac: indeed unuran is not present in Homebrew.

I just proposed a new homebrew formula: Homebrew/homebrew-core#288800

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

Formula merged! So unuran is now part of homebrew.

@ferdymercury

This comment was marked as outdated.

@ferdymercury ferdymercury requested a review from guitargeek as a code owner June 28, 2026 21:09

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! This is a strict improvement over shipping the sources in a tar ball.

@guitargeek guitargeek merged commit 1e9e7d3 into root-project:master Jun 30, 2026
32 of 34 checks passed
@ferdymercury ferdymercury deleted the bunur2 branch June 30, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants