[nfc][cmake] mention that some builtins are no longer bundled#21596
[nfc][cmake] mention that some builtins are no longer bundled#21596ferdymercury wants to merge 14 commits into
Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 103ece7. ♻️ This comment has been updated with latest results. |
|
Thanks. When zstd is merged #21597 and zlib is added to the bundle, this will be merged (and maybe topped up with lzma, which is treated the same. |
|
Thanks for the feedback Danilo :) btw, builtin_xxhash looks like another candidate for off-loading to LCG, in the context of compression |
AFAIK the policy is to keep anything that is strictly required to build minimal ROOT as vendored code and xxhash is one such dependency (required e.g. to build RNTuple) |
I think we are about to abandon this policy. For things that are readily available in most Linuxes and in homebrew, we suggest, in order of preference:
Only option 3 requires network during the configure step. All others could be performed offline. |
but require internet connection [cmake] two more
as suggested by dpiparo
| ROOT_BUILD_OPTION(builtin_gsl OFF "Build GSL internally (requires network) [GPL]") | ||
| ROOT_BUILD_OPTION(builtin_gtest OFF "Build googletest internally (requires network)") | ||
| ROOT_BUILD_OPTION(builtin_jpeg OFF "Build bundled copy of libjpeg") | ||
| ROOT_BUILD_OPTION(builtin_civetweb ON "Build civetweb from an externally provided source tarball (requires network)") |
but require internet connection