fix(android): block initial URL load in sandbox mode#16
Merged
janicduplessis merged 1 commit intorainbow-customizations-part1from Apr 15, 2026
Merged
Conversation
shouldOverrideUrlLoading doesn't fire for the initial source URL, so sandboxed WebViews could load blocked domains as their first page. Added host allowlist check in onPageStarted — if the domain isn't allowed, stops loading and emits onReceivedError so the JS onError callback fires.
olerass
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #14.
Fixes a bug where sandboxed WebViews could load blocked domains as their initial page. Tested this with the new sandbox e2e test here.
Problem
shouldOverrideUrlLoadingdoesn't fire for the initial source URL on Android. This means when a WebView is in sandbox mode, the very first page load bypasses the host allowlist check entirely, allowing blocked domains to render.Fix
onPageStarted— if the domain isn't in the allowed list,stopLoading()is called immediatelyonReceivedErrorso the JSonErrorcallback fires, letting the app handle the blocked navigationonReceivedErrorcall in the existingshouldOverrideUrlLoadingblock so both code paths now consistently report errors back to JS