fix(android): block initial URL load in sandbox mode#19
Merged
janicduplessis merged 1 commit intomasterfrom Apr 16, 2026
Merged
fix(android): block initial URL load in sandbox mode#19janicduplessis merged 1 commit intomasterfrom
janicduplessis merged 1 commit intomasterfrom
Conversation
shouldOverrideUrlLoading doesn't fire for the initial source URL, so sandboxed WebViews could load blocked domains as their first page. Added host allowlist check in onPageStarted — if the domain isn't allowed, stops loading and emits onReceivedError so the JS onError callback fires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #16 was merged into
rainbow-customizations-part1by mistake, so this replacement PR carries the same Android sandbox fix directly ontomaster.When a WebView is in sandbox mode, Android does not call
shouldOverrideUrlLoadingfor the initial source URL. That lets a blocked host render as the first page load even though later navigations are checked against the allowlist.Solution
This adds the allowlist check to
onPageStartedand emitsonReceivedErrorwhen the initial URL is blocked, so the initial load path behaves the same way as the existing blocked-navigation path.Test plan
master