Skip to content

Add eviction writeback callback to FeatureEvict (#5832) #5832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lizhe-ji wants to merge 1 commit into from
Closed

Add eviction writeback callback to FeatureEvict (#5832) #5832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fbgemm_gpu/fbgemm_gpu/tbe/ssd/ssd_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ class EvictionPolicy(NamedTuple):
enable_eviction_for_feature_score_eviction_policy: list[bool] | None = (
None # enable eviction if eviction policy is feature score, false means no eviction
)
enable_ssd_writeback: bool = (
False # when True, evicted dirty blocks are written back to SSD via callback; when False, eviction deletes blocks directly
)

def validate(self) -> None:
assert self.eviction_trigger_mode in [0, 1, 2, 3, 4, 5], (
Expand Down
1 change: 1 addition & 0 deletions fbgemm_gpu/fbgemm_gpu/tbe/ssd/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,6 +956,7 @@ def __init__(
eviction_policy.interval_for_insufficient_eviction_s,
eviction_policy.interval_for_sufficient_eviction_s,
eviction_policy.interval_for_feature_statistics_decay_s,
eviction_policy.enable_ssd_writeback,
)
enrichment_config = None
if (
Expand Down
Loading
Loading