Add eviction writeback callback to FeatureEvict (#5832)#5832
Closed
lizhe-ji wants to merge 1 commit into
Closed
Conversation
lizhe-ji
force-pushed
the
export-D107491725
branch
from
June 4, 2026 19:21
5599df8 to
c156d29
Compare
meta-codesync
Bot
changed the title
lizhe-ji
force-pushed
the
export-D107491725
branch
from
June 4, 2026 21:40
c156d29 to
11d0d0d
Compare
lizhe-ji
pushed a commit
to lizhe-ji/FBGEMM-1
that referenced
this pull request
Jun 4, 2026
Summary: X-link: facebookresearch/FBGEMM#2754 Add EvictionWritebackCallback type and wire it through FeatureEvict eviction loops. When a dirty block is evicted from DRAM, its data is serialized and passed to the callback for writeback to SSD. The callback is invoked after releasing the DRAM shard lock to avoid holding locks during SSD I/O. Differential Revision: D107491725
lizhe-ji
force-pushed
the
export-D107491725
branch
from
June 5, 2026 01:18
11d0d0d to
6c0c5cb
Compare
lizhe-ji
pushed a commit
to lizhe-ji/FBGEMM-1
that referenced
this pull request
Jun 5, 2026
Summary: X-link: facebookresearch/FBGEMM#2754 Add EvictionWritebackCallback type and wire it through FeatureEvict eviction loops. When a dirty block is evicted from DRAM, its data is serialized and passed to the callback for writeback to SSD. The callback is invoked after releasing the DRAM shard lock to avoid holding locks during SSD I/O. Differential Revision: D107491725
lizhe-ji
pushed a commit
to lizhe-ji/FBGEMM-1
that referenced
this pull request
Jun 9, 2026
Summary: X-link: facebookresearch/FBGEMM#2754 Add EvictionWritebackCallback type and wire it through FeatureEvict eviction loops. When a dirty block is evicted from DRAM, its data is serialized and passed to the callback for writeback to SSD. The callback is invoked after releasing the DRAM shard lock to avoid holding locks during SSD I/O. Differential Revision: D107491725
lizhe-ji
force-pushed
the
export-D107491725
branch
from
June 9, 2026 04:31
6c0c5cb to
1628c1e
Compare
lizhe-ji
pushed a commit
to lizhe-ji/FBGEMM-1
that referenced
this pull request
Jun 11, 2026
Summary: X-link: facebookresearch/FBGEMM#2754 Add EvictionWritebackCallback type and wire it through FeatureEvict eviction loops. When a dirty block is evicted from DRAM, its data is serialized and passed to the callback for writeback to SSD. The callback is invoked after releasing the DRAM shard lock to avoid holding locks during SSD I/O. Differential Revision: D107491725
lizhe-ji
force-pushed
the
export-D107491725
branch
from
June 11, 2026 00:21
1628c1e to
524325d
Compare
lizhe-ji
pushed a commit
to lizhe-ji/FBGEMM-1
that referenced
this pull request
Jun 11, 2026
Summary: X-link: facebookresearch/FBGEMM#2754 Add EvictionWritebackCallback type and wire it through FeatureEvict eviction loops. When a dirty block is evicted from DRAM, its data is serialized and passed to the callback for writeback to SSD. The callback is invoked after releasing the DRAM shard lock to avoid holding locks during SSD I/O. Differential Revision: D107491725
lizhe-ji
force-pushed
the
export-D107491725
branch
2 times, most recently
from
June 13, 2026 07:22
bf7002d to
4366eff
Compare
lizhe-ji
pushed a commit
to lizhe-ji/FBGEMM-1
that referenced
this pull request
Jun 13, 2026
Summary: X-link: facebookresearch/FBGEMM#2754 Add EvictionWritebackCallback type and wire it through FeatureEvict eviction loops. When a dirty block is evicted from DRAM, its data is serialized and passed to the callback for writeback to SSD. The callback is invoked after releasing the DRAM shard lock to avoid holding locks during SSD I/O. Reviewed By: EddyLXJ Differential Revision: D107491725
Summary: X-link: facebookresearch/FBGEMM#2754 Add EvictionWritebackCallback type and wire it through FeatureEvict eviction loops. When a dirty block is evicted from DRAM, its data is serialized and passed to the callback for writeback to SSD. The callback is invoked after releasing the DRAM shard lock to avoid holding locks during SSD I/O. Reviewed By: EddyLXJ Differential Revision: D107491725
lizhe-ji
force-pushed
the
export-D107491725
branch
from
June 15, 2026 18:09
4366eff to
8b934a9
Compare
Contributor
|
This pull request has been merged in 1eab597. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2754
Add EvictionWritebackCallback type and wire it through FeatureEvict eviction loops. When a dirty block is evicted from DRAM, its data is serialized and passed to the callback for writeback to SSD. The callback is invoked after releasing the DRAM shard lock to avoid holding locks during SSD I/O.
Reviewed By: EddyLXJ
Differential Revision: D107491725