DOC: Execute 1_loading_datasets notebook to populate cell outputs#1707
Open
romanlutz wants to merge 1 commit into
Open
DOC: Execute 1_loading_datasets notebook to populate cell outputs#1707romanlutz wants to merge 1 commit into
romanlutz wants to merge 1 commit into
Conversation
The notebook was committed without execution, so the published docs page at https://microsoft.github.io/PyRIT/code/datasets/loading-datasets/ rendered all code cells without output. Re-execute the notebook so readers see the dataset list, sample seed values, and memory query results. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eeee2345
added a commit
to eeee2345/PyRIT
that referenced
this pull request
May 11, 2026
@romanlutz pointed out the manual entry in 0_dataset.md is a small hardcoded subset; the canonical list is generated by re-executing 1_loading_datasets.ipynb (which his microsoft#1707 handles). Dropping the manual line; auto-registration via SeedDatasetProvider already ensures agent_threat_rules appears in the regenerated notebook output once microsoft#1707 lands.
jsong468
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The published docs page at https://microsoft.github.io/PyRIT/code/datasets/loading-datasets/ renders all code cells with no output because the committed
doc/code/datasets/1_loading_datasets.ipynbwas checked in unexecuted (execution_count: nulland emptyoutputson every code cell). The site renders the.ipynbas-is — it doesn't execute notebooks at build time — so readers see only the source.Sibling notebooks in the same folder (e.g.,
2_seed_programming.ipynb) were committed with their outputs and render fine.Change
Re-executed the notebook with
jupytext --to notebook --executeand ran the standard pre-commit hooks (sanitize_notebook_paths,strip_notebook_progress_bars,nbstripoutwith--keep-output). The.pyand.ipynbremain in sync.Readers will now see:
airt_illegalandairt_malwarememory.get_seeds(...)resultsNo source code changes.