DOC: Fix trailing-space typo in 4_dataset_coding sample code#1710
Open
romanlutz wants to merge 1 commit intomicrosoft:mainfrom
Open
DOC: Fix trailing-space typo in 4_dataset_coding sample code#1710romanlutz wants to merge 1 commit intomicrosoft:mainfrom
romanlutz wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The SimpleDarkBench example in doc/code/datasets/4_dataset_coding.ipynb passes `config=\"default \"` (trailing space) to `_fetch_from_huggingface`. The real DarkBenchDataset loader uses `config=\"default\"`. The trailing space would cause the HuggingFace API to fail to find the config if anyone copy-pasted the example. Re-executed the notebook for hygiene; the only cell defines a class without instantiating it, so there is no visible output to populate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
SimpleDarkBenchexample indoc/code/datasets/4_dataset_coding.ipynbpassesconfig=\"default \"(trailing space) to_fetch_from_huggingface. The realDarkBenchDatasetloader usesconfig=\"default\". The trailing space would cause the HuggingFace API to fail to find the config if anyone copy-pasted the example.Why now
Noticed while auditing notebooks that have
execution_count: null(no cell outputs) on the published docs site (follow-up to #1707). This notebook's only cell defines a class without instantiating it, so the missing output is expected — but the typo is real. Re-executed the notebook for hygiene; the .py and .ipynb stay in sync.