Skip to content

ci: compressed size workflow now using temporary branch with my changes built into compressed-size-action #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimhigson merged 1 commit into from
Apr 15, 2026
Merged

ci: compressed size workflow now using temporary branch with my changes built into compressed-size-action #802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/compressed-size.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
node-version: 25.x
cache: "pnpm"
- name: Game bundle size
uses: jimhigson/compressed-size-action@903b75ad9d180d0e863d38f441f20de5cdc44046 # until merged: https://github.com/preactjs/compressed-size-action/pull/146
uses: jimhigson/compressed-size-action@base-ref-with-build # until merged: https://github.com/preactjs/compressed-size-action/pull/146

Copilot AI Apr 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a mutable branch ref (@base-ref-with-build) for an action makes CI non-reproducible and can break unexpectedly if the branch is force-pushed or deleted. Pin this to a specific commit SHA (or immutable tag) on the fork while waiting for the upstream PR to merge, and update the inline comment accordingly.

Copilot uses AI. Check for mistakes.
with:
build-script: "build:game"
clean-script: "clean"
Expand All @@ -36,7 +36,7 @@ jobs:
# commit before running the second action
- uses: actions/checkout@v6
- name: Editor bundle size
uses: jimhigson/compressed-size-action@903b75ad9d180d0e863d38f441f20de5cdc44046 # until merged: https://github.com/preactjs/compressed-size-action/pull/146
uses: jimhigson/compressed-size-action@base-ref-with-build # until merged: https://github.com/preactjs/compressed-size-action/pull/146

Copilot AI Apr 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here: referencing jimhigson/compressed-size-action@base-ref-with-build uses a mutable branch and can change without review. Prefer pinning the action to a commit SHA (or immutable tag) to keep results reproducible and avoid supply-chain risk.

Copilot uses AI. Check for mistakes.
with:
build-script: "build:editor"
clean-script: "clean"
Expand Down