ci: compressed size workflow now using temporary branch with my changes built into compressed-size-action - #802
Merged
Conversation
…es built into compressed-size-action
✅ Deploy Preview for blockstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jimhigson
enabled auto-merge (squash)
April 15, 2026 17:07
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s “Compressed Size” GitHub Actions workflow to use a temporary branch of a forked compressed-size-action that includes pending changes (referenced in preactjs/compressed-size-action#146).
Changes:
- Switch
jimhigson/compressed-size-actionfrom a pinned commit SHA to a temporary branch ref for the Game bundle size step. - Switch
jimhigson/compressed-size-actionfrom a pinned commit SHA to a temporary branch ref for the Editor bundle size step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - uses: actions/checkout@v6 | ||
| - name: Editor bundle size | ||
| uses: jimhigson/compressed-size-action@903b75ad9d180d0e863d38f441f20de5cdc44046 # until merged: https://github.com/preactjs/compressed-size-action/pull/146 | ||
| uses: jimhigson/compressed-size-action@base-ref-with-build # until merged: https://github.com/preactjs/compressed-size-action/pull/146 |
There was a problem hiding this comment.
Same issue here: referencing jimhigson/compressed-size-action@base-ref-with-build uses a mutable branch and can change without review. Prefer pinning the action to a commit SHA (or immutable tag) to keep results reproducible and avoid supply-chain risk.
| cache: "pnpm" | ||
| - name: Game bundle size | ||
| uses: jimhigson/compressed-size-action@903b75ad9d180d0e863d38f441f20de5cdc44046 # until merged: https://github.com/preactjs/compressed-size-action/pull/146 | ||
| uses: jimhigson/compressed-size-action@base-ref-with-build # until merged: https://github.com/preactjs/compressed-size-action/pull/146 |
There was a problem hiding this comment.
Using a mutable branch ref (@base-ref-with-build) for an action makes CI non-reproducible and can break unexpectedly if the branch is force-pushed or deleted. Pin this to a specific commit SHA (or immutable tag) on the fork while waiting for the upstream PR to merge, and update the inline comment accordingly.
Contributor
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 2.36 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.