fix: support on/off boolean values in reader#883
Merged
Conversation
Handle Word on/off boolean attribute values in the reader and prefer w:val when parsing booleans so run properties are interpreted correctly. Made-with: Cursor
Run the wasm TypeScript build with the pnpm-managed compiler and install with a frozen lockfile so CI stays aligned with the pinned dependency versions. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onandoffvalues when reading Word boolean attributes in the readerw:valover the first attribute when parsing booleans to avoid misreading XML attributeson/offparsing andw:valselectionTest plan
cargo test -p docx-rs test_read_on_off_valuescargo test -p docx-rs test_read_bool_prefers_val_attributecargo test -p docx-rs test_is_false_supports_offcargo test -p docx-rs test_read_italic_falsecargo test -p docx-rs test_read_italic_0Made with Cursor