Skip to content

fix: support on/off boolean values in reader#883

Merged
bokuweb merged 2 commits intomainfrom
fix-reader-on-off-bool
Apr 2, 2026
Merged

fix: support on/off boolean values in reader#883
bokuweb merged 2 commits intomainfrom
fix-reader-on-off-bool

Conversation

@bokuweb
Copy link
Copy Markdown
Owner

@bokuweb bokuweb commented Apr 2, 2026

Summary

  • support on and off values when reading Word boolean attributes in the reader
  • prefer w:val over the first attribute when parsing booleans to avoid misreading XML attributes
  • add regression tests for on/off parsing and w:val selection

Test plan

  • cargo test -p docx-rs test_read_on_off_values
  • cargo test -p docx-rs test_read_bool_prefers_val_attribute
  • cargo test -p docx-rs test_is_false_supports_off
  • cargo test -p docx-rs test_read_italic_false
  • cargo test -p docx-rs test_read_italic_0

Made with Cursor

bokuweb added 2 commits April 2, 2026 19:37
Handle Word on/off boolean attribute values in the reader and prefer w:val when parsing booleans so run properties are interpreted correctly.

Made-with: Cursor
Run the wasm TypeScript build with the pnpm-managed compiler and install with a frozen lockfile so CI stays aligned with the pinned dependency versions.

Made-with: Cursor
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

This report was generated by comparing 8f9f5cc with 20a7079.
If you would like to check difference, please check here.

success

ArtifactName: wasm

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 46
change 0
new 0
delete 0

@bokuweb bokuweb merged commit 77f5506 into main Apr 2, 2026
11 checks passed
@bokuweb bokuweb deleted the fix-reader-on-off-bool branch April 2, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant