fix: support on/off boolean values in reader (#883)

* fix: support on/off boolean values in reader

Handle Word on/off boolean attribute values in the reader and prefer w:val when parsing booleans so run properties are interpreted correctly.

Made-with: Cursor

* fix: use pinned TypeScript in wasm CI

Run the wasm TypeScript build with the pnpm-managed compiler and install with a frozen lockfile so CI stays aligned with the pinned dependency versions.

Made-with: Cursor

Author: bokuweb

.github/workflows/ci.yml

@@ -70,7 +70,7 @@ jobs:
       - run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
       - run: rustup target add wasm32-unknown-unknown
       - run: npm install -g pnpm
-      - run: pnpm install && pnpm wasm-pack:node && pnpm wasm-pack:dev && tsc -p tsconfig.node.json && pnpm test
+      - run: pnpm install --frozen-lockfile && pnpm wasm-pack:node && pnpm wasm-pack:dev && pnpm exec tsc -p tsconfig.node.json && pnpm test
       - name: screenshot
         run: pnpm screenshot
       - uses: reg-viz/reg-actions@v3

docx-core/src/reader/attributes/bool_value.rs

@@ -1,14 +1,45 @@
 use crate::reader::OwnedAttribute;
 
 pub fn is_false(v: &str) -> bool {
-    v == "0" || v == "false"
+    v == "0" || v.eq_ignore_ascii_case("false") || v.eq_ignore_ascii_case("off")
 }
 
 pub fn read_bool(attrs: &[OwnedAttribute]) -> bool {
-    if let Some(v) = attrs.first() {
-        if is_false(&v.value) {
-            return false;
-        }
+    if let Some(v) = attrs
+        .iter()
+        .find(|attr| attr.name.local_name == "val")
+        .or_else(|| attrs.first())
+    {
+        return !is_false(&v.value);
     }
     true
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::reader::OwnedName;
+
+    fn attr(local_name: &str, value: &str) -> OwnedAttribute {
+        OwnedAttribute {
+            name: OwnedName {
+                local_name: local_name.to_string(),
+                namespace: None,
+                prefix: Some("w".to_string()),
+            },
+            value: value.to_string(),
+        }
+    }
+
+    #[test]
+    fn test_is_false_supports_off() {
+        assert!(is_false("off"));
+        assert!(is_false("OFF"));
+    }
+
+    #[test]
+    fn test_read_bool_prefers_val_attribute() {
+        let attrs = vec![attr("foo", "false"), attr("val", "on")];
+        assert!(read_bool(&attrs));
+    }
+}

docx-core/src/reader/run.rs

@@ -312,6 +312,31 @@ mod tests {
         );
     }
 
+    #[test]
+    fn test_read_on_off_values() {
+        let c = r#"<w:document xmlns:w="http://schemas.openxmlformats.org/wordprocessingml/2006/main">
+  <w:r><w:rPr>
+    <w:b w:val="off"/>
+    <w:i w:val="on"/>
+  </w:rPr></w:r>
+</w:document>"#;
+        let mut parser = EventReader::new(c.as_bytes());
+        let run = Run::read(&mut parser, &[]).unwrap();
+        assert_eq!(
+            run,
+            Run {
+                children: vec![],
+                run_property: RunProperty {
+                    bold: Some(Bold::new().disable()),
+                    bold_cs: Some(BoldCs::new().disable()),
+                    italic: Some(Italic::new()),
+                    italic_cs: Some(ItalicCs::new()),
+                    ..RunProperty::default()
+                },
+            }
+        );
+    }
+
     #[test]
     fn test_read_fit_text() {
         let c = r#"<w:document xmlns:w="http://schemas.openxmlformats.org/wordprocessingml/2006/main">