Skip to content

fix(ops): fail fast on missing backup method - #10818

Merged
leon-ape merged 1 commit into
mainfrom
bugfix/10816-scaleout-backupmethod-fail-fast
Aug 30, 2026
Merged

fix(ops): fail fast on missing backup method#10818
leon-ape merged 1 commit into
mainfrom
bugfix/10816-scaleout-backupmethod-fail-fast

Conversation

@leon-ape

Copy link
Copy Markdown
Collaborator

Fixes #10816.

Problem

A Backup may report status.phase: Completed while status.backupMethod is empty. The restore plan detects that invalid state before any Restore exists, but its non-terminal error currently leaves the horizontal-scaling OpsRequest retrying instead of failing.

Changes

  • keep detection of the incomplete Backup status in the shared restore plan
  • classify the plan's RestoreFailed result as fatal at the scale-out Operations boundary
  • verify the completed-without-backupMethod case is terminal and creates no Restore

Scope

This PR only changes missing-backupMethod error classification for scale-out restore. It does not change restore environment propagation, namespaces, authorization, VolumeSnapshot behavior, or source-target selection.

This is the narrow fail-fast replacement for the corresponding part of #10597.

Validation

  • scripts/codex-go-test.sh ./pkg/operations -count=1
  • git diff --check

@leon-ape
leon-ape requested review from a team and wangyelei as code owners August 28, 2026 09:12
@apecloud-bot

Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

CLA Recheck Instructions

Usage:
  - /recheck-cla: Trigger a re-check of CLA status for this pull request.
Example:
  - /recheck-cla

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.69%. Comparing base (98453e1) to head (3032839).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10818      +/-   ##
==========================================
+ Coverage   65.61%   65.69%   +0.07%     
==========================================
  Files         510      510              
  Lines       64403    64405       +2     
==========================================
+ Hits        42259    42309      +50     
+ Misses      18382    18346      -36     
+ Partials     3762     3750      -12     
Flag Coverage Δ
unittests 65.69% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-ape leon-ape added the nopick Not auto cherry-pick when PR merged label Aug 28, 2026
@leon-ape

Copy link
Copy Markdown
Collaborator Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Aug 28, 2026
@leon-ape
leon-ape merged commit 8295e5e into main Aug 30, 2026
54 of 56 checks passed
@leon-ape
leon-ape deleted the bugfix/10816-scaleout-backupmethod-fail-fast branch August 30, 2026 04:58
@github-actions github-actions Bot added this to the Release 1.2.0 milestone Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ops): fail fast on completed Backup without backupMethod

2 participants