Skip to content

fix(ops): fail fast on missing backup method - #10822

Merged
leon-ape merged 2 commits into
release-1.1from
bugfix/10816-backupmethod-fail-fast-release-1.1
Aug 30, 2026
Merged

fix(ops): fail fast on missing backup method#10822
leon-ape merged 2 commits into
release-1.1from
bugfix/10816-backupmethod-fail-fast-release-1.1

Conversation

@leon-ape

Copy link
Copy Markdown
Collaborator

Fixes #10816.

Release 1.1 counterpart of #10818.

Problem

A Backup may report status.phase: Completed while status.backupMethod is empty. The restore plan detects that invalid state, but the scale-out OpsRequest keeps retrying because the error is not terminal.

Changes

  • keep detection of the incomplete Backup status in the shared restore plan
  • classify its RestoreFailed result as fatal at the scale-out Operations boundary
  • verify the invalid completed Backup is terminal and creates no Restore

Scope

This PR only changes missing-backupMethod error classification on release-1.1. It does not change restore environment, namespaces, authorization, VolumeSnapshot behavior, no-target-volume handling, or source-target selection.

Validation

  • scripts/codex-go-test.sh ./pkg/operations -count=1
  • git diff --check

@leon-ape
leon-ape requested a review from a team as a code owner August 28, 2026 10:18
@leon-ape leon-ape added the nopick Not auto cherry-pick when PR merged label Aug 28, 2026
@github-actions github-actions Bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 28, 2026
@apecloud-bot

Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

CLA Recheck Instructions

Usage:
  - /recheck-cla: Trigger a re-check of CLA status for this pull request.
Example:
  - /recheck-cla

@leon-ape leon-ape changed the title [release-1.1] fix(ops): fail fast on missing backup method fix(ops): fail fast on missing backup method [release-1.1] Aug 28, 2026
@leon-ape leon-ape changed the title fix(ops): fail fast on missing backup method [release-1.1] chore(ops): backport missing backup method fail-fast [release-1.1] Aug 28, 2026
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.50%. Comparing base (316faf0) to head (88a463e).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.1   #10822      +/-   ##
===============================================
- Coverage        55.52%   55.50%   -0.02%     
===============================================
  Files              550      550              
  Lines            62326    62328       +2     
===============================================
- Hits             34604    34595       -9     
- Misses           24407    24413       +6     
- Partials          3315     3320       +5     
Flag Coverage Δ
unittests 55.50% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-ape leon-ape changed the title chore(ops): backport missing backup method fail-fast [release-1.1] fix(ops): fail fast on missing backup method Aug 30, 2026
@leon-ape

Copy link
Copy Markdown
Collaborator Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Aug 30, 2026
@leon-ape leon-ape linked an issue Aug 30, 2026 that may be closed by this pull request
@leon-ape leon-ape added this to the Release 1.1.0 milestone Aug 30, 2026
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Aug 30, 2026
@leon-ape
leon-ape merged commit 3708470 into release-1.1 Aug 30, 2026
37 of 39 checks passed
@leon-ape
leon-ape deleted the bugfix/10816-backupmethod-fail-fast-release-1.1 branch August 30, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nopick Not auto cherry-pick when PR merged size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ops): fail fast on completed Backup without backupMethod

2 participants