fix(ops): fail fast on missing backup method - #10822
Merged
leon-ape merged 2 commits intoAug 30, 2026
Merged
Conversation
(cherry picked from commit 3032839)
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.1 #10822 +/- ##
===============================================
- Coverage 55.52% 55.50% -0.02%
===============================================
Files 550 550
Lines 62326 62328 +2
===============================================
- Hits 34604 34595 -9
- Misses 24407 24413 +6
- Partials 3315 3320 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10816.
Release 1.1 counterpart of #10818.
Problem
A Backup may report status.phase: Completed while status.backupMethod is empty. The restore plan detects that invalid state, but the scale-out OpsRequest keeps retrying because the error is not terminal.
Changes
Scope
This PR only changes missing-backupMethod error classification on release-1.1. It does not change restore environment, namespaces, authorization, VolumeSnapshot behavior, no-target-volume handling, or source-target selection.
Validation