fix(ops): fail fast on missing backup method - #10818
Merged
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
This was referenced Aug 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10818 +/- ##
==========================================
+ Coverage 65.61% 65.69% +0.07%
==========================================
Files 510 510
Lines 64403 64405 +2
==========================================
+ Hits 42259 42309 +50
+ Misses 18382 18346 -36
+ Partials 3762 3750 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Aug 28, 2026
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10816.
Problem
A Backup may report
status.phase: Completedwhilestatus.backupMethodis empty. The restore plan detects that invalid state before any Restore exists, but its non-terminal error currently leaves the horizontal-scaling OpsRequest retrying instead of failing.Changes
RestoreFailedresult as fatal at the scale-out Operations boundaryScope
This PR only changes missing-backupMethod error classification for scale-out restore. It does not change restore environment propagation, namespaces, authorization, VolumeSnapshot behavior, or source-target selection.
This is the narrow fail-fast replacement for the corresponding part of #10597.
Validation
scripts/codex-go-test.sh ./pkg/operations -count=1git diff --check