only hide auth login options if there is no available - #2529
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
9 tasks
chaitanyapotti
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
https://consensyssoftware.atlassian.net/browse/EMBED-446
Locales PR
Web3Auth/web3auth-locales#239
Description
Improves the modal UX when only external wallets are available. The login page is now shown/hidden based on whether any auth login options (social logins, passwordless input, or an external wallet button) are actually available, rather than special-casing MetaMask. This prevents auto-skipping into the wallet list and keeps navigation consistent.
Changes
ModalStateContext—shouldShowLoginPagenow keys offshowExternalWalletButtoninstead of hardcoding a MetaMask check, so the login page is hidden only when there are genuinely no auth login options to show.Login— removed theuseEffectthat auto-invokedhandleConnectWallet()when only external wallets were visible, avoiding the forced skip into the wallet screen.ConnectWallet— dropped theisExternalWalletModeOnlyprop and its back-button special-casing; back-button visibility now depends solely on whether a wallet is selected.isExternalWalletModeOnlyfromConnectWallet.type.tsand the prop pass-through inRoot.modalManager— when initializing external connectors (no in-app wallet available),externalWalletsVisibilityis set tofalseso the flow renders through the standard modal state instead of forcing the external-only view.external.all-walletslabel from "All Wallets" to "Other wallets" across all locale files.How has this been tested?
Screenshots (if appropriate)
No social/auth enabled
web3auth-modal-external-wallet-only.mov
No installed wallets example
no-installed-wallets.mov
Types of changes
Checklist
Note
Medium Risk
Changes first-screen routing and when login vs wallet list renders across connector configurations; UX-only but affects all modal connect flows when auth methods are disabled.
Overview
Fixes modal flow when only external wallets are configured: the login screen is no longer skipped or auto-advanced into the wallet list unless there is genuinely nothing to show there.
shouldShowLoginPagenow treats any visible external-wallet entry point viashowExternalWalletButton(not a MetaMask-only check), so the sign-in page stays available when installed wallets or “other wallets” discovery is offered.modalManagerinitializes external-only setups withexternalWalletsVisibility: false, avoiding the forced external-only view on open.Loginno longer auto-invokes the wallet list when social/passwordless are off.ConnectWalletdropsisExternalWalletModeOnlyand related back-button hiding.Copy update:
external.all-walletsis renamed to “Other wallets” across locales.Reviewed by Cursor Bugbot for commit c2e6ead. Bugbot is set up for automated code reviews on this repo. Configure here.