Skip to content

only hide auth login options if there is no available - #2529

Merged
chaitanyapotti merged 1 commit into
masterfrom
feat/only-external-wallet-view-ux
Jul 22, 2026
Merged

only hide auth login options if there is no available#2529
chaitanyapotti merged 1 commit into
masterfrom
feat/only-external-wallet-view-ux

Conversation

@lionellbriones

@lionellbriones lionellbriones commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Jira Link

https://consensyssoftware.atlassian.net/browse/EMBED-446

Locales PR

Web3Auth/web3auth-locales#239

Description

Improves the modal UX when only external wallets are available. The login page is now shown/hidden based on whether any auth login options (social logins, passwordless input, or an external wallet button) are actually available, rather than special-casing MetaMask. This prevents auto-skipping into the wallet list and keeps navigation consistent.

Changes

  • ModalStateContextshouldShowLoginPage now keys off showExternalWalletButton instead of hardcoding a MetaMask check, so the login page is hidden only when there are genuinely no auth login options to show.
  • Login — removed the useEffect that auto-invoked handleConnectWallet() when only external wallets were visible, avoiding the forced skip into the wallet screen.
  • ConnectWallet — dropped the isExternalWalletModeOnly prop and its back-button special-casing; back-button visibility now depends solely on whether a wallet is selected.
    • Removed isExternalWalletModeOnly from ConnectWallet.type.ts and the prop pass-through in Root.
  • modalManager — when initializing external connectors (no in-app wallet available), externalWalletsVisibility is set to false so the flow renders through the standard modal state instead of forcing the external-only view.
  • i18n — renamed the external.all-wallets label from "All Wallets" to "Other wallets" across all locale files.

How has this been tested?

Screenshots (if appropriate)

No social/auth enabled

web3auth-modal-external-wallet-only.mov

No installed wallets example

no-installed-wallets.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note

Medium Risk
Changes first-screen routing and when login vs wallet list renders across connector configurations; UX-only but affects all modal connect flows when auth methods are disabled.

Overview
Fixes modal flow when only external wallets are configured: the login screen is no longer skipped or auto-advanced into the wallet list unless there is genuinely nothing to show there.

shouldShowLoginPage now treats any visible external-wallet entry point via showExternalWalletButton (not a MetaMask-only check), so the sign-in page stays available when installed wallets or “other wallets” discovery is offered.

modalManager initializes external-only setups with externalWalletsVisibility: false, avoiding the forced external-only view on open. Login no longer auto-invokes the wallet list when social/passwordless are off. ConnectWallet drops isExternalWalletModeOnly and related back-button hiding.

Copy update: external.all-wallets is renamed to “Other wallets” across locales.

Reviewed by Cursor Bugbot for commit c2e6ead. Bugbot is set up for automated code reviews on this repo. Configure here.

@lionellbriones
lionellbriones requested a review from a team as a code owner July 21, 2026 15:22
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web3auth-web Ready Ready Preview, Comment Jul 21, 2026 3:22pm

Request Review

@chaitanyapotti
chaitanyapotti merged commit 71a80ce into master Jul 22, 2026
7 checks passed
@chaitanyapotti
chaitanyapotti deleted the feat/only-external-wallet-view-ux branch July 22, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants