change all wallet to other wallet - #239
Merged
Merged
Conversation
lionellbriones
marked this pull request as ready for review
July 21, 2026 15:21
8 tasks
chaitanyapotti
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
https://consensyssoftware.atlassian.net/browse/EMBED-446
Description
Copywriting update base on this PR
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Note
Low Risk
Copy-only locale updates with no logic or key renames; low risk aside from possible product/UX expectation that the label now means “other” rather than “all.”
Overview
Updates the
modal.external.all-walletscopy inlocale-common.jsonso the external-wallet UI label reads “Other wallets” instead of “All Wallets” in every supported locale (English plus amharic, dutch, french, german, japanese, korean, mandarin, portuguese, spanish, turkish).This is a wording-only change; the locale key is unchanged, so consumers still resolve the same string id with new translations (e.g. French Autres portefeuilles, German Andere Wallets).
Reviewed by Cursor Bugbot for commit 0af0c87. Bugbot is set up for automated code reviews on this repo. Configure here.