25 implementation of topological torsion fingerprint - #78
Merged
LukaszSztukiewicz merged 15 commits intoJan 30, 2026
Merged
Conversation
…topological-torsion-fingerprint
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
the unit tests are disabled, thats why code coverage is so bad |
…topological-torsion-fingerprint
LukaszSztukiewicz
approved these changes
Jan 30, 2026
LukaszSztukiewicz
left a comment
LukaszSztukiewicz
left a comment
Owner
There was a problem hiding this comment.
Thanks a lot for that @julepilgrim ! That's really good work :)
LGTM!
LukaszSztukiewicz
deleted the
25-implementation-of-topological-torsion-fingerprint
branch
January 30, 2026 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add hashed version of topological torsion fingerprint and hashed version as bitvec and do some refactoring
add tests of new functions
edit some comments and docstrings