Skip to content

chore: remove lucy-2.1-vton #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdirAmsalem merged 1 commit into from
Jun 30, 2026
Merged

chore: remove lucy-2.1-vton #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/decart/models.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace models {

/// Resolve a realtime model by name.
///
/// Accepts canonical names ("lucy-2.1", "lucy-2.1-vton", "lucy-vton-2",
/// Accepts canonical names ("lucy-2.1", "lucy-vton-2",
/// "lucy-vton-3", "lucy-restyle-2"), server-resolved aliases ("lucy-latest",
/// "lucy-vton-latest", "lucy-restyle-latest"), and deprecated names (which emit
/// no error but resolve to the same stream endpoint).
Expand Down
4 changes: 1 addition & 3 deletions src/models.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,9 @@ struct Entry {

// Realtime model registry. Kept in sync with the shared model list across the
// Decart SDKs. All realtime models stream over `/v1/stream` at 30 fps.
constexpr std::array<Entry, 11> kRealtime = {{
constexpr std::array<Entry, 9> kRealtime = {{
// Canonical
{"lucy-2.1", 1088, 624, true},
{"lucy-2.1-vton", 1088, 624, true},
{"lucy-vton-2", 1088, 624, true},
{"lucy-vton-3", 1088, 624, true},
{"lucy-restyle-2", 1280, 704, true},
Expand All @@ -33,7 +32,6 @@ constexpr std::array<Entry, 11> kRealtime = {{
{"lucy-restyle-latest", 1280, 704, false},
// Deprecated aliases (still accepted)
{"mirage_v2", 1280, 704, false},
{"lucy-vton", 1088, 624, false},
{"lucy-2.1-vton-2", 1088, 624, false},
}};

Expand Down
4 changes: 2 additions & 2 deletions tests/test_models.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ TEST_CASE("realtime() accepts latest and deprecated aliases") {
CHECK(models::realtime("lucy-latest").urlPath == "/v1/stream");
CHECK(models::realtime("lucy-vton-latest").name == "lucy-vton-latest");
CHECK(models::realtime("mirage_v2").width == 1280); // deprecated -> restyle geometry
CHECK(models::isRealtimeModel("lucy-vton"));
CHECK(models::isRealtimeModel("lucy-2.1-vton-2"));
}

TEST_CASE("realtime() throws ModelNotFound for unknown names") {
Expand All @@ -41,6 +41,6 @@ TEST_CASE("realtime() throws ModelNotFound for unknown names") {
TEST_CASE("listRealtime() honors canonicalOnly") {
auto all = models::listRealtime(/*canonicalOnly=*/false);
auto canonical = models::listRealtime(/*canonicalOnly=*/true);
CHECK(canonical.size() == 5);
CHECK(canonical.size() == 4);
CHECK(all.size() > canonical.size());
}
Loading