Add PNG as slow random access codec#729
Merged
cedrik-fuoco-adsk merged 2 commits intoAcademySoftwareFoundation:mainfrom Mar 26, 2025
Merged
Add PNG as slow random access codec#729cedrik-fuoco-adsk merged 2 commits intoAcademySoftwareFoundation:mainfrom
cedrik-fuoco-adsk merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
cedrik-fuoco-adsk
force-pushed
the
fix-png-perf
branch
from
5dc7ac9 to
e97cbbd
Compare
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
force-pushed
the
fix-png-perf
branch
from
e97cbbd to
96a06c9
Compare
Contributor
Author
|
All the comments have been addressed in the previous commit. |
eloisebrosseau
approved these changes
Mar 26, 2025
cedrik-fuoco-adsk
merged commit 4da8831
into
AcademySoftwareFoundation:main
10 checks passed
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Mar 26, 2025
### Add PNG as slow random access codec ### Linked issues n/a ### Summarize your change. Adding PNG codec to the slow random access array and changing the seeking offset to -1 instead of -3 because RV was using that an offset of -1 before FFmpeg 6. ### Describe the reason for the change. There are some issues when RV is using two readers threads and FFmpeg multithreading. By adding PNG as a slow random access codec, the decoding performance is a lot better. ### Describe what you have tested and on which operating system. Rocky Linux 8 An offset of -1 during seeking had better performance during my testing. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
richardssam
pushed a commit
to richardssam/OpenRV
that referenced
this pull request
Jun 17, 2025
### Add PNG as slow random access codec ### Linked issues n/a ### Summarize your change. Adding PNG codec to the slow random access array and changing the seeking offset to -1 instead of -3 because RV was using that an offset of -1 before FFmpeg 6. ### Describe the reason for the change. There are some issues when RV is using two readers threads and FFmpeg multithreading. By adding PNG as a slow random access codec, the decoding performance is a lot better. ### Describe what you have tested and on which operating system. Rocky Linux 8 An offset of -1 during seeking had better performance during my testing. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
richardssam
pushed a commit
to richardssam/OpenRV
that referenced
this pull request
Jun 17, 2025
### Add PNG as slow random access codec ### Linked issues n/a ### Summarize your change. Adding PNG codec to the slow random access array and changing the seeking offset to -1 instead of -3 because RV was using that an offset of -1 before FFmpeg 6. ### Describe the reason for the change. There are some issues when RV is using two readers threads and FFmpeg multithreading. By adding PNG as a slow random access codec, the decoding performance is a lot better. ### Describe what you have tested and on which operating system. Rocky Linux 8 An offset of -1 during seeking had better performance during my testing. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PNG as slow random access codec
Linked issues
n/a
Summarize your change.
Adding PNG codec to the slow random access array and changing the seeking offset to -1 instead of -3 because RV was using that an offset of -1 before FFmpeg 6.
Describe the reason for the change.
There are some issues when RV is using two readers threads and FFmpeg multithreading. By adding PNG as a slow random access codec, the decoding performance is a lot better.
Describe what you have tested and on which operating system.
Rocky Linux 8
An offset of -1 during seeking had better performance during my testing.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.