constexpr and PR comments

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Author: cedrik-fuoco-adsk

src/lib/image/MovieFFMpeg/MovieFFMpeg.cpp

@@ -24,6 +24,7 @@
 #include <math.h>
 #include <algorithm>
 #include <array>
+#include <string_view>
 #include <stdlib.h>
 #include <stl_ext/stl_ext_algo.h>
 #include <stl_ext/string_algo.h>
@@ -70,7 +71,6 @@ namespace TwkMovie
 #define FPS_PRECISION_LIMIT 1000 // 5 sig figs
 #define RV_OUTPUT_VIDEO_CODEC "mjpeg"
 #define RV_OUTPUT_AUDIO_CODEC "pcm_s16be"
-#define RV_SEEK_FRAME_OFFSET 1
 
 #if 0
 #define DB_LOG_LEVEL AV_LOG_ERROR
@@ -620,6 +620,7 @@ namespace TwkMovie
 
     namespace
     {
+        constexpr int rv_seek_frame_offset = 1;
 
         //----------------------------------------------------------------------
         //
@@ -632,18 +633,16 @@ namespace TwkMovie
         //  actually support. But just in case ....
         //
 
-        const char* slowRandomAccessCodecsArray[] = {
-            "3iv2", "3ivd", "ap41",       "avc1",
-            "div1", "div2", "div3",       "div4",
-            "div5", "div6", "divx",       "dnxhd",
-            "dx50", "h263", "h264",       "i263",
-            "iv31", "iv32", "m4s2",       "mp42",
-            "mp43", "mp4s", "mp4v",       "mpeg4",
-            "mpg1", "mpg3", "mpg4",       "pim1",
-            "png",  "s263", "svq1",       "svq3",
-            "u263", "vc1",  "vc1_vdpau",  "vc1image",
-            "viv1", "wmv3", "wmv3_vdpau", "wmv3image",
-            "xith", "xvid", "libdav1d",   0};
+        constexpr std::array<std::string_view, 44> slowRandomAccessCodecs = {
+            "3iv2",     "3ivd",  "ap41",     "avc1",       "div1",
+            "div2",     "div3",  "div4",     "div5",       "div6",
+            "divx",     "dnxhd", "dx50",     "h263",       "h264",
+            "i263",     "iv31",  "iv32",     "m4s2",       "mp42",
+            "mp43",     "mp4s",  "mp4v",     "mpeg4",      "mpg1",
+            "mpg3",     "mpg4",  "pim1",     "png",        "s263",
+            "svq1",     "svq3",  "u263",     "vc1",        "vc1_vdpau",
+            "vc1image", "viv1",  "wmv3",     "wmv3_vdpau", "wmv3image",
+            "xith",     "xvid",  "libdav1d", nullptr};
 
         const char* supportedEncodingCodecsArray[] = {
             "dvvideo", "libx264", "mjpeg", "pcm_s16be", "rawvideo", 0};
@@ -723,15 +722,17 @@ namespace TwkMovie
         bool codecHasSlowAccess(string name)
         {
             boost::algorithm::to_lower(name);
-            for (const char** p = slowRandomAccessCodecsArray; *p; p++)
+            for (const std::string_view& codec : slowRandomAccessCodecs)
             {
-                if (*p == name)
+                std::cout << "Comparing " << codec << " with " << name
+                          << std::endl;
+                if (codec == name)
                 {
                     return true;
                 }
             }
             return false;
-        };
+        }
 
         bool isMP4format(AVFormatContext* avFormatContext)
         {
@@ -3321,7 +3322,7 @@ namespace TwkMovie
         // for now. Note: FFmpeg internally seeks with the dts timestamp and not
         // the pts timestamp. We need to have a bit of a buffer.
         const int64_t seekTarget =
-            int64_t((inframe - RV_SEEK_FRAME_OFFSET) * frameDur);
+            int64_t((inframe - rv_seek_frame_offset) * frameDur);
 
         DBL(DB_VIDEO, "seekTarget: " << seekTarget
                                      << " last: " << track->lastDecodedVideo
@@ -3450,7 +3451,7 @@ namespace TwkMovie
     {
         // The goal timestamp is the same as the seek target adjusted
         // for pts vs dts.
-        const int64_t goalTS = (inframe - RV_SEEK_FRAME_OFFSET) * frameDur;
+        const int64_t goalTS = (inframe - rv_seek_frame_offset) * frameDur;
 
         // If it is the first time we try to decode the stream, we need
         // to start by reading a packet.