chore: fix all-passed gate to run with if: always()#11
Open
Conversation
The all-passed job depends on lint-commits which is always skipped on push events (due to its if: github.event_name == 'pull_request' conditional). GitHub Actions propagates skipped status to dependent jobs, so all-passed was silently skipped on every run and never actually gated anything. Adding if: always() ensures the gate job runs regardless of skipped dependencies, and the step now verifies that no jobs failed or were cancelled instead of unconditionally reporting success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The all-passed job depends on lint-commits which is always skipped
on push events (due to its
if: github.event_name == 'pull_request'conditional). GitHub Actions propagates skipped status to dependent
jobs, so all-passed was silently skipped on every run and never
actually gated anything.
Adding
if: always()ensures the gate job runs regardless of skippeddependencies, and the step now verifies that no jobs failed or were
cancelled instead of unconditionally reporting success.