Fix double free in pipe_t::process_pipe_term_ack - #4853
Merged
Conversation
bluca
reviewed
Jul 2, 2026
bluca
force-pushed
the
fix/pipe-term-ack-double-free
branch
from
July 2, 2026 19:04
412790c to
09c9dd0
Compare
bluca
force-pushed
the
fix/pipe-term-ack-double-free
branch
from
July 2, 2026 19:07
09c9dd0 to
5993468
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_in_pipepointer was being used to drain messages and then deleted viaLIBZMQ_DELETE, but the command dispatch loop inio_thread_t::in_eventprocesses all mailbox commands in a single pass. If a second command arrives for the samepipe_tafterdelete thisis executed, the object's memory has already been freed and_in_pipebecomes a dangling pointer, leading to a double free.This fix saves
_in_pipeto a local and nulls out the member before draining, so any stale access to the deleted object sees NULL rather than a freed ypipe pointer. Fixes #4806.