fix: replace assert with early return in out_event when _io_error is set - #4852
Closed
ssam18 wants to merge 1 commit into
Closed
fix: replace assert with early return in out_event when _io_error is set#4852ssam18 wants to merge 1 commit into
ssam18 wants to merge 1 commit into
Conversation
Member
|
If an assert is hit it means there is a programming error somewhere else that results in an invalid/undefined state. Just removing the assert and ignoring the error is wrong and leaves the underlying problem lurking about. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the I/O thread collects both POLLIN and POLLOUT from the same epoll_wait batch, processing the POLLIN can set _io_error via in_event_internal(), and the already-queued POLLOUT still gets dispatched to out_event() — hitting the assert and crashing. Replacing the assert with an early return handles this gracefully, consistent with the same guard already present in restart_output(). Fixes #4841.