fix: prevent STT and refinement model settings from being randomly overwritten#58
Open
fix: prevent STT and refinement model settings from being randomly overwritten#58
Conversation
…erwritten The config GUI was randomly overwriting user's model selections due to provider-specific caching issues: 1. Cache only updated on <<ComboboxSelected>>, missing typed values 2. List validation reset non-listed models to first dropdown item 3. Sync methods used new provider instead of old when switching Fixes: - Add _sync_stt_model_to_cache() and _sync_refinement_model_to_cache() helper methods to keep cache in sync with GUI state - Use list membership to determine which provider's cache to save to when switching providers (since provider var is already updated) - Remove list validation when restoring from cache to preserve custom/non-listed models - Call sync methods in set_values() to handle config loading 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
_sync_stt_model_to_cache()and_sync_refinement_model_to_cache()helper methods_on_stt_model_changed()and_on_refinement_model_changed()to use sync helpers_update_stt_model_options()and_update_refinement_model_options()to:set_values()to call sync methods after setting model valuesTest plan
test_stt_model_preserved_when_switching_providerspasses🤖 Generated with Claude Code