Enhance icon rendering in Menu widget to support custom tag.#94
Open
terabytesoftw wants to merge 16 commits intomasterfrom
Open
Enhance icon rendering in Menu widget to support custom tag.#94terabytesoftw wants to merge 16 commits intomasterfrom
Menu widget to support custom tag.#94terabytesoftw wants to merge 16 commits intomasterfrom
Conversation
Member
terabytesoftw
commented
May 4, 2025
terabytesoftw
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
…hub.com/yiisoft/yii-widgets into add-support-menu-widget-custom-tag-icon
vjik
requested changes
May 4, 2025
samdark
reviewed
May 5, 2025
samdark
approved these changes
May 6, 2025
vjik
requested changes
May 10, 2025
| $html = Span::tag()->attributes($iconContainerAttributes)->content($i)->encode(false)->render(); | ||
| $html = Html::tag($tagName)->attributes($iconAttributes)->content($icon)->render(); | ||
|
|
||
| if ($tagName === 'i') { |
Member
There was a problem hiding this comment.
Wrapping usage that depends from tag name is very unexpected.
This package contains common framework-agnostic widgets, so result should be defined clearly. Use container or not, should be defined clearly and not depend from tag name.
Member
Author
There was a problem hiding this comment.
The change is about the handling of icons, which are usually wrapped in a container, while SVGs, for example, are not wrapped, just like an image. But i understand the proposal, i will improve it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.