Add Menu::collapseAfter() for overflow dropdown - #141
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 327 342 +15
===========================================
Files 8 8
Lines 1038 1082 +44
===========================================
+ Hits 1038 1082 +44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
|
Code review findings:
Checks run locally on the PR branch:
|
What does this PR do?
Adds
Menu::collapseAfter()to keep the first N visible items in place and move the rest into a "More" dropdown.New methods:
collapseAfter(?int),collapseLabel(string), andcollapseDropdownDefinitions(?array). The defaultcollapseAftervalue isnull, so all items stay visible. Invisible items don't count toward the threshold. The collapse dropdown reusesdropdownDefinitions()unlesscollapseDropdownDefinitions()is set separately.No BC break: the new behavior is disabled by default, and existing menu output is unchanged unless
collapseAfter()is set.