Add widgets configuration file (#436)#452
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #452 +/- ##
=========================================
Coverage 76.96% 76.96%
Complexity 29 29
=========================================
Files 11 11
Lines 178 178
=========================================
Hits 137 137
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbuhonov
force-pushed
the
feature/436-widgets-config
branch
from
4968b27 to
eed0b70
Compare
There was a problem hiding this comment.
Pull request overview
Adds the missing web widgets configuration file requested in issue #436, aligning the web config structure with other existing config entries under config/web.
Changes:
- Add
config/web/widgets.phpwith a strict-types header and an (initially empty) configuration array.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vjik
left a comment
vjik
left a comment
There was a problem hiding this comment.
Add this file to config/configuration.php.
… feature/436-widgets-config # Conflicts: # config/web/widgets.php
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CHANGELOG.md
Outdated
|
|
||
| ## 1.2.1 under development | ||
|
|
||
| - Chg #452: Add widgets configuration file (@dbuhonov) |
There was a problem hiding this comment.
config/configuration.php
Outdated
| '$widgets', | ||
| 'web/widgets.php', | ||
| ], | ||
| 'widgets-console' => '$widgets', |
There was a problem hiding this comment.
Do we need widgets for the console?
| 'events-web' => ['$events'], | ||
| 'events-console' => ['$events'], | ||
| 'widgets' => [], | ||
| 'widgets-web' => [ |
There was a problem hiding this comment.
Configure Yii Widgets params. See example: https://github.com/yiisoft/demo-diary/blob/675115b0879881e117ed09dc6d77a64a93ebf38f/config/site/params.php#L17
There was a problem hiding this comment.
yiisoft/widget is not installed in this project, so I dont quite understand what is expected here besides adding an empty configuration file. Could you clarify what should be configured in this case?
There was a problem hiding this comment.
yiisoft/widgetis not installed in this project, so I dont quite understand what is expected here besides adding an empty configuration file. Could you clarify what should be configured in this case?
Oh, sorry, I missed it 😞. In this case this issue is not actual.
Uh oh!
There was an error while loading. Please reload this page.