chore: add initial github ci & fix tests#17
Merged
bsbds merged 2 commits intoxorbitsai:masterfrom Mar 20, 2026
Merged
Conversation
rogercloud
reviewed
Mar 18, 2026
rogercloud
left a comment
rogercloud
left a comment
There was a problem hiding this comment.
Code Review Summary
Overall Status: ✅ APPROVED with minor suggestions
This PR is well-structured with comprehensive tests (8/8 passing). The refactoring moves from bundled model files to a flexible download system with good backward compatibility.
Findings: 2 minor issues - see inline comments
deepdoc/common/model_store.py
Outdated
| TOKENIZER_MODEL_DIR_ENV = "DEEPDOC_TOKENIZER_MODEL_DIR" | ||
|
|
||
|
|
||
| def _parse_bool(value: str | None, default: bool = False) -> bool: |
There was a problem hiding this comment.
Minor: Code Duplication
The _parse_bool function is duplicated here and in the new file deepdoc/config.py:18-21. Consider extracting to a common utility module like deepdoc/common/__init__.py to avoid duplication.
.github/workflows/ci.yml
Outdated
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.12" |
There was a problem hiding this comment.
Minor: CI Coverage Gap
pyproject.toml declares requires-python = ">=3.10,<3.14" (supporting 3.10-3.13), but CI only tests 3.12. Consider using matrix testing:
strategy:
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13"]
fix: tests
rogercloud
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.