fix: Deprecate the url: import feature#2465
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
==========================================
+ Coverage 79.32% 79.35% +0.03%
==========================================
Files 134 134
Lines 4005 4006 +1
Branches 910 910
==========================================
+ Hits 3177 3179 +2
- Misses 736 737 +1
+ Partials 92 90 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
|
@aklinker1 Can I directly merge this PR? |
aklinker1
left a comment
There was a problem hiding this comment.
Can you also add a warning when the vite plugin sees a URL import?
wxt/packages/wxt/src/core/builders/vite/plugins/download.ts
Lines 30 to 33 in f14ec35
That way people using it get a warning in dev mode and during builds.
|
You shouldn't be able to merge your own PRs, an approval from someone other than the author is required. You can enable auto-merge, that way when it gets approved it's merged immediately after all checks are passing and it has approval. |
|
@nishu-murmu If you write |
|
@nishu-murmu If you're eager, you can join us on Discord |
url: import feature
…ev/wxt into chore/deprecate-url-import-feature
Overview
Currently showing the deprecation warning in the docs for
url:import feature until the major branch is merged.Manual Testing
bun docs:genandbun docs:dev.Related Issue
This PR doesn't closes #2262 is a part of that issue.