feat: features usage of the exact negotiated stream id limit#58
feat: features usage of the exact negotiated stream id limit#58wmnsk merged 9 commits intowmnsk:mainfrom
Conversation
wmnsk
left a comment
There was a problem hiding this comment.
Thanks! Two things:
- as a library used behind apps, I wouldn’t like to log unless users explicitly enable it. I think they can just be removed, but if you think they’re really important, consider adding logger like this. IMO just logging without returning error is not really useful though.
- Please don’t leave comments here and there - if they’re important for users, please add them in godoc. Otherwise, remove them (or, if the code may confuse developers, leave some explanations but not every line).
|
Thanks for the review. |
|
sorry I’ve been on vacation and not in front of my computer. I think I can review next week. |
wmnsk
left a comment
There was a problem hiding this comment.
Left a lot of comments, but mostly the same stuff. Thanks for your patience!
Co-authored-by: Yoshiyuki Kurauchi <ahochauwaaaaa@gmail.com>
Co-authored-by: Yoshiyuki Kurauchi <ahochauwaaaaa@gmail.com>
|
Thanks for the review. |
|
Thanks for the review. |
wmnsk
left a comment
There was a problem hiding this comment.
Looks great, thank you for your contribution!
Perhaps we could look into another way to cleanup the underlying connection in case of errors, but not necessary here :)
Hi @wmnsk
This PR updates to the latest Ishida Wataru SCTP dependency library. With this update, we feature getting the maximum negotiated stream ID, which can be used by the user. Exceeding the max negotiated stream ID will throw an error from the system.