WPB-23789: refactor galley conversation helm charts#5175
Open
blackheaven wants to merge 5 commits intodevelopfrom
Open
WPB-23789: refactor galley conversation helm charts#5175blackheaven wants to merge 5 commits intodevelopfrom
blackheaven wants to merge 5 commits intodevelopfrom
Conversation
zebot
added
the
ok-to-test
supersven
reviewed
Apr 10, 2026
| defaults: | ||
| status: disabled | ||
| lockStatus: locked | ||
| mlsPrivateKeyPaths: |
Contributor
There was a problem hiding this comment.
These seem to be the same values as in the values.yaml of the chart. What is the benefit of redefining them here?
I would only redefine what's new. However, opinions may differ.
supersven
reviewed
Apr 10, 2026
| {{- end -}} | ||
|
|
||
| {{/* SHARED SETTINGS */}} | ||
| {{- define "wire-server.settings.common" -}} |
Contributor
There was a problem hiding this comment.
I'm sorry, but I'm not convinced of this change.
A lot of values here seem to be not common, but specific to Galley. 🤔
It might also be confusing for admins to see ConfigMaps with values that are unused.
Contributor
Author
There was a problem hiding this comment.
In an upcoming PR #5126 they will be used by background-worker.
supersven
reviewed
Apr 10, 2026
| This consolidation improves code organization and separation of concerns for conversation logic. | ||
|
|
||
| * Chart configuration changes: | ||
| - Added `global.settings` section to deduplicate shared configuration between galley and background-worker services |
Contributor
There was a problem hiding this comment.
This change is not in this patch, right? (I might be short sighted, but I haven't seen background-worker related changes in this PR 😅 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-24072
Checklist
changelog.d