Skip to content

feat: add encrypt_targeted_message() [WPB-27214] - #2421

Merged
SimonThormeyer merged 8 commits into
mainfrom
simon/feat/targeted-message-message-enum
Aug 12, 2026
Merged

feat: add encrypt_targeted_message() [WPB-27214]#2421
SimonThormeyer merged 8 commits into
mainfrom
simon/feat/targeted-message-message-enum

Conversation

@SimonThormeyer

@SimonThormeyer SimonThormeyer commented Jul 31, 2026

Copy link
Copy Markdown
Member

This is further partial work for WPB-27214.

Remaining after this

  • nonce handling on the receiver side
  • decrypt_targeted_message()
  • encrypt/decrypt tests

@SimonThormeyer SimonThormeyer changed the title Simon/feat/targeted message message enum Simon/feat/targeted message message Jul 31, 2026
@SimonThormeyer
SimonThormeyer force-pushed the simon/feat/targeted-message-message-enum branch 2 times, most recently from 5b8aa73 to 34df367 Compare July 31, 2026 16:02
@SimonThormeyer SimonThormeyer changed the title Simon/feat/targeted message message Simon/feat/targeted messag Jul 31, 2026
@SimonThormeyer
SimonThormeyer force-pushed the simon/feat/targeted-message-message-enum branch 3 times, most recently from 9c62a4d to 3f2cb40 Compare August 3, 2026 11:46
@SimonThormeyer SimonThormeyer changed the title Simon/feat/targeted messag feat: add encrypt_targeted_message() [WPB-27214] Aug 3, 2026
@SimonThormeyer
SimonThormeyer force-pushed the simon/feat/targeted-message-message-enum branch 4 times, most recently from 1109e04 to 45adba9 Compare August 3, 2026 12:08
@SimonThormeyer
SimonThormeyer marked this pull request as ready for review August 3, 2026 12:16
@SimonThormeyer
SimonThormeyer requested a review from a team August 3, 2026 12:16
Comment thread crypto/src/mls/core_crypto_message/mod.rs Outdated
Comment thread crypto/src/mls/core_crypto_message/targeted.rs Outdated
Comment thread crypto/src/mls/conversation/mutable/tnt/targeted/mod.rs
Comment thread crypto/src/mls/conversation/mutable/tnt/targeted.rs Outdated
Comment thread crypto/src/mls/core_crypto_message/targeted.rs Outdated
Comment thread crypto/src/mls/conversation/immutable/mod.rs Outdated
Comment thread crypto/src/mls/conversation/mutable/group_mutation.rs
Comment thread crypto/src/mls/conversation/mutable/encrypt_targeted.rs Outdated
@SimonThormeyer
SimonThormeyer force-pushed the simon/feat/targeted-message-message-enum branch 2 times, most recently from 4d7d34a to f85455d Compare August 4, 2026 08:49
@SimonThormeyer
SimonThormeyer force-pushed the simon/feat/targeted-message-message-enum branch from f85455d to 4a009a6 Compare August 4, 2026 08:50
Comment thread crypto/src/mls/conversation/mutable/encrypt_targeted.rs
Comment thread crypto/src/mls/conversation/mutable/encrypt_targeted.rs Outdated

@fewerner fewerner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to add from my side. GJ so far!

Comment thread crypto/src/mls/core_crypto_message/targeted.rs Outdated
@SimonThormeyer
SimonThormeyer force-pushed the simon/feat/targeted-message-message-enum branch 2 times, most recently from 7b84325 to 1691aec Compare August 4, 2026 10:13
@SimonThormeyer
SimonThormeyer force-pushed the simon/feat/targeted-message-message-enum branch from 1691aec to b4e4296 Compare August 4, 2026 13:12
Comment thread crypto-ffi/src/core_crypto_context/mls.rs Outdated
Comment thread crypto-ffi/src/core_crypto_context/mls.rs Outdated
Comment thread crypto/src/mls/conversation/mutable/encrypt_targeted.rs Outdated
Comment thread crypto/src/mls/conversation/mutable/encrypt_targeted.rs Outdated
@SimonThormeyer
SimonThormeyer force-pushed the simon/feat/targeted-message-message-enum branch 3 times, most recently from c5f4302 to 8494050 Compare August 6, 2026 15:28
Comment thread crypto/src/mls/conversation/mutable/tnt/mod.rs
Comment thread crypto/src/mls/conversation/mutable/tnt/mod.rs
Comment thread crypto/src/mls/conversation/mutable/tnt/sender_nonce.rs Outdated
Comment thread crypto/src/mls/conversation/mutable/tnt/targeted.rs Outdated
Comment thread crypto/src/mls/conversation/mutable/tnt/mod.rs Outdated
Comment thread crypto/src/mls/conversation/mutable/tnt/targeted.rs Outdated
Comment thread crypto/src/mls/conversation/mutable/group_mutation.rs
@istankovic

Copy link
Copy Markdown
Member

We still have CoreCryptoMessage in a few places:

crypto/src/mls/conversation/mutable/tnt/targeted.rs:70:    pub(super) const SIGN_LABEL_PERSISTED: &str = "CoreCryptoMessageTBS-Persisted-Targeted";
crypto/src/mls/conversation/mutable/tnt/targeted.rs:71:    pub(super) const SIGN_LABEL_TRANSIENT: &str = "CoreCryptoMessageTBS-Transient-Targeted";
crypto/src/mls/conversation/mutable/tnt/encrypt_targeted.rs:69:            .map_err(OpenMlsError::wrap("signing CoreCryptoMessageTBS"))?;
crypto/src/mls/conversation/mutable/tnt/encrypt_targeted.rs:73:            .map_err(Error::tls_serialize("CoreCryptoMessage: targeted"))

Comment thread crypto/src/mls/conversation/mutable/tnt/targeted.rs Outdated
@SimonThormeyer
SimonThormeyer force-pushed the simon/feat/targeted-message-message-enum branch 3 times, most recently from c4d8b39 to 5772332 Compare August 11, 2026 09:47
@SimonThormeyer
SimonThormeyer force-pushed the simon/feat/targeted-message-message-enum branch 2 times, most recently from e352cb3 to bacd63d Compare August 12, 2026 09:41

@istankovic istankovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🍷

@SimonThormeyer
SimonThormeyer force-pushed the simon/feat/targeted-message-message-enum branch from bacd63d to 740424a Compare August 12, 2026 12:45
@SimonThormeyer
SimonThormeyer merged commit 740424a into main Aug 12, 2026
36 checks passed
@SimonThormeyer
SimonThormeyer deleted the simon/feat/targeted-message-message-enum branch August 12, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants