Clarify supply-chain risk framing for external JSON keybindings fetch#2786
Closed
Copilot wants to merge 1 commit intofix/vsc-default-keybindings-copyfrom
Closed
Clarify supply-chain risk framing for external JSON keybindings fetch#2786Copilot wants to merge 1 commit intofix/vsc-default-keybindings-copyfrom
Copilot wants to merge 1 commit intofix/vsc-default-keybindings-copyfrom
Conversation
|
Copilot
AI
changed the title
[WIP] Update keybindings fix based on review feedback
Clarify supply-chain risk framing for external JSON keybindings fetch
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reviewer flagged fetching from
refs/heads/masterofcodebling/vs-code-default-keybindingsas a "supply-chain risk." This PR addresses the follow-up question of whether that concern is a real security threat given the project only consumes and produces JSON.Assessment
The concern is not a code-execution security risk:
JSON.parse()produces data structures only — no code is evaluatedisVscKeybinding()before useThe actual risk is operational reliability:
package.jsonkeybindings over timePinning to a commit SHA would address reproducibility at the cost of no longer automatically picking up upstream keybinding updates — a deliberate tradeoff, not a security fix.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.