feat: use post instead of get to support secure tokens#15
Open
feat: use post instead of get to support secure tokens#15
Conversation
osandell
force-pushed
the
feature/change-to-post-requests
branch
from
8814050 to
0dda880
Compare
Member
|
Looks good to me @osandell |
johanwestin
requested review from
johanwestin
and removed request for
johanwestin
Member
|
Github mobile är lite rörigt. Ändringen ser solid ut tycker jag. POST är väl alltid bättre än GET på sånt här. Kommer det fungera för äldre Matomo installationer? Vet inte riktigt hur länge secure tokens varit en grej för Matomo. |
Author
Just det, det vore ju bra att kolla. Har vi nån sajt med gammal version man kan testa på? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Märkte att Staffanstorp fick 403 iom att en api-token var skapad som 'secure' och därmed kräver POST-requests för att få ut data. Bytte ut den för nu men tänkte att det kanske vore bra att byta till POST här för att stödja båda varianter av tokens?
Har dålig koll på det här repot så vet inte om det ställer till det på nåt annat sätt, bara en idé.