Skip to content

Add shuffle/1#211

Merged
whatyouhide merged 3 commits intowhatyouhide:mainfrom
spicychickensauce:shuffle
Mar 28, 2025
Merged

Add shuffle/1#211
whatyouhide merged 3 commits intowhatyouhide:mainfrom
spicychickensauce:shuffle

Conversation

@spicychickensauce
Copy link
Copy Markdown
Contributor

As per #160

I have tried to understand LazyTree, but I don't get it.
Do you have any learning resources so that I could implement it properly and get the desired shrinking behaviour?

@spicychickensauce
Copy link
Copy Markdown
Contributor Author

@whatyouhide
Changing to the clojure implementation results in proper shrinking.
What do you think? Is this good enough or is there something to be gained by going more low level using LazyTree?

@spicychickensauce spicychickensauce marked this pull request as ready for review March 12, 2025 10:33
@spicychickensauce
Copy link
Copy Markdown
Contributor Author

@whatyouhide Sorry for pinging, but do you have any feedback here?

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 167d9afee0e1b310c355188b5adf5665a36aa96b-PR-211

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 94.307%

Totals Coverage Status
Change from base Build 1c291fee2535be043f6d9762e2dbd1ead1b5520f: 0.1%
Covered Lines: 381
Relevant Lines: 404

💛 - Coveralls

@whatyouhide whatyouhide merged commit fe67bd3 into whatyouhide:main Mar 28, 2025
2 checks passed
@whatyouhide
Copy link
Copy Markdown
Owner

Sorry for the delay! Looking great 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants